Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 388587 - sys-apps/portage-2.1.10.31: repoman full warns about changelog.ebuildadded even if repoman commit should add changelog entry
Summary: sys-apps/portage-2.1.10.31: repoman full warns about changelog.ebuildadded ev...
Status: RESOLVED INVALID
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 17:52 UTC by Pacho Ramos
Modified: 2011-10-27 20:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
add opts and repo config debug output (repoman_debug.patch,1.96 KB, patch)
2011-10-27 06:04 UTC, Zac Medico
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2011-10-26 17:52:42 UTC
I want to simply run:
repoman manifest
repoman full
-> repoman commit -m "blablabla" 

to let repoman generate ChangeLog entry (and don't need to manually run echangelog), but repoman full asks me to create changelog entry before:

$ repoman full

RepoMan scours the neighborhood...
  inherit.autotools             1
   dev-cpp/atkmm/atkmm-2.22.5.ebuild: no eauto* function called
  dependency.unknown            4
   dev-cpp/atkmm/atkmm-2.22.5.ebuild: DEPEND: !<dev-cpp/gtkmm-2.22.0
   dev-cpp/atkmm/atkmm-2.22.5.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.22.0
   dev-cpp/atkmm/atkmm-2.22.6.ebuild: DEPEND: !<dev-cpp/gtkmm-2.22.0
   dev-cpp/atkmm/atkmm-2.22.6.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.22.0
  changelog.ebuildadded         1
   dev-cpp/atkmm/atkmm-2.22.6.ebuild

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

Please fix these important QA issues first.
RepoMan sez: "Make your QA payment on time and you'll never see the likes of me."


I think this worked ok with 2.1.10.30 or previous version :-/

Thanks

Reproducible: Always
Comment 1 Zac Medico gentoo-dev 2011-10-26 18:00:16 UTC
I think maybe you just need to update metadata/layout.conf. It's required since this change:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=7f9e716d4198f90032d91e8e8adfbc6d7673883c
Comment 2 Pacho Ramos gentoo-dev 2011-10-26 18:13:13 UTC
I have this one:

# This goes live after stabilization of portage-2.1.10.21
#manifest-hashes = SHA256 SHA512 WHIRLPOOL

# Bug #337853 - gentoo's council says to enable
# --echangelog by default for the "gentoo" repo
update-changelog = true
Comment 3 Zac Medico gentoo-dev 2011-10-26 18:21:37 UTC
Please post the output of `repoman -v full`.

Also, do you have a REPOMAN_DEFAULT_OPTS setting in make.conf?
Comment 4 Pacho Ramos gentoo-dev 2011-10-26 18:51:14 UTC
(In reply to comment #3)
> Please post the output of `repoman -v full`.
> 
> Also, do you have a REPOMAN_DEFAULT_OPTS setting in make.conf?

No, I don't set any repoman option :-/

The output:

$ repoman -v full
[INFO] Setting paths:
[INFO] PORTDIR = "/home/pacho/gentoo-x86"
[INFO] PORTDIR_OVERLAY = ""

RepoMan scours the neighborhood...
[INFO] checking package dev-cpp/pangomm
  dependency.unknown            4
   dev-cpp/pangomm/pangomm-2.28.2.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.3.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.4.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.5.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
  changelog.ebuildadded         1
   dev-cpp/pangomm/pangomm-2.28.5.ebuild

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

Please fix these important QA issues first.
RepoMan sez: "Make your QA payment on time and you'll never see the likes of me."


(I would also drop that dependency.unknown warning when referring to blockers, but it's a different history I guess ;))
Comment 5 Zac Medico gentoo-dev 2011-10-26 19:55:28 UTC
Given the current repoman logic in portage-2.1.10.31, the output that you're getting doesn't seem possible. Please use `which repoman` to verify the path of the repoman version that you are running, and also verify that it's identical to the version of repoman that comes with portage-2.1.10.31:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blob_plain;f=bin/repoman;hb=f00cb26ae12964893de74ac7cc75ce9016991366
Comment 6 Pacho Ramos gentoo-dev 2011-10-26 20:01:09 UTC
(In reply to comment #5)
> Given the current repoman logic in portage-2.1.10.31, the output that you're
> getting doesn't seem possible. Please use `which repoman` to verify the path of
> the repoman version that you are running, and also verify that it's identical
> to the version of repoman that comes with portage-2.1.10.31:
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blob_plain;f=bin/repoman;hb=f00cb26ae12964893de74ac7cc75ce9016991366

$ which repoman
/usr/bin/repoman


$ diff -u index.html\?p\=proj%2Fportage.git\;a\=blob_plain\;f\=bin%2Frepoman\;hb\=f00cb26ae12964893de74ac7cc75ce9016991366 /usr/bin/repoman 

Looks the same :-/
Comment 7 Zac Medico gentoo-dev 2011-10-26 20:10:27 UTC
Better also do `type repoman` to make sure it's not a shell alias.
Comment 8 Pacho Ramos gentoo-dev 2011-10-26 22:43:08 UTC
(In reply to comment #7)
> Better also do `type repoman` to make sure it's not a shell alias.

$ type repoman
repoman is /usr/bin/repoman
Comment 9 Zac Medico gentoo-dev 2011-10-27 05:41:55 UTC
Does it behave differently if you add --echangelog=y to the repoman options?
Comment 10 Zac Medico gentoo-dev 2011-10-27 06:04:45 UTC
Created attachment 290979 [details, diff]
add opts and repo config debug output

Save as /tmp/repoman_debug.patch and apply as follows:

 cd /usr/lib/portage
 patch -p1 < /tmp/repoman_debug.patch

Then if you run `repoman -vv full`, it should show some debug messages like these:

[DEBUG] repo config: {'disable_manifest': False, 'cache_format': 'pms', 'create_manifest': True, 'allow_missing_manifest': False, 'sync': 'rsync://rsync.gentoo.org/gentoo-portage', 'thin_manifest': False, 'main_repo': None, 'missing_repo_name': False, 'aliases': None, 'eclass_overrides': None, 'sign_manifest': True, 'user_location': '/home/pacho/gentoo-x86', 'priority': 5, 'location': '/home/pacho/gentoo-x86', 'manifest_hashes': None, 'update_changelog': True, 'format': None, 'masters': (), 'name': 'gentoo', 'eclass_locations': ('/mnt/portage/cvs',)}
[DEBUG] options: {'include_dev': False, 'force': False, 'version': None, 'if_modified': 'n', 'commitmsg': None, 'ignore_arches': False, 'verbosity': 2, 'pretend': False, 'quiet': 0, 'xml_parse': False, 'ignore_masked': False, 'ignore_default_opts': None, 'vcs': None, 'mode': 'full', 'commitmsgfile': None, 'ask': False, 'without_mask': False, 'echangelog': 'y', 'unmatched_removal': False}
Comment 11 Pacho Ramos gentoo-dev 2011-10-27 09:16:25 UTC
(In reply to comment #9)
> Does it behave differently if you add --echangelog=y to the repoman options?

It seems to work:

$ repoman --echangelog=y full

RepoMan scours the neighborhood...
  dependency.unknown            4
   dev-cpp/pangomm/pangomm-2.28.2.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.3.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.4.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.5.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

RepoMan sez: "You're only giving me a partial QA payment?
              I'll take it this time, but I'm not happy."

(In reply to comment #10)
> Created attachment 290979 [details, diff]
> add opts and repo config debug output
> 
> Save as /tmp/repoman_debug.patch and apply as follows:
> 
>  cd /usr/lib/portage
>  patch -p1 < /tmp/repoman_debug.patch
> 
> Then if you run `repoman -vv full`, it should show some debug messages like
> these:
> 
> [DEBUG] repo config: {'disable_manifest': False, 'cache_format': 'pms',
> 'create_manifest': True, 'allow_missing_manifest': False, 'sync':
> 'rsync://rsync.gentoo.org/gentoo-portage', 'thin_manifest': False, 'main_repo':
> None, 'missing_repo_name': False, 'aliases': None, 'eclass_overrides': None,
> 'sign_manifest': True, 'user_location': '/home/pacho/gentoo-x86', 'priority':
> 5, 'location': '/home/pacho/gentoo-x86', 'manifest_hashes': None,
> 'update_changelog': True, 'format': None, 'masters': (), 'name': 'gentoo',
> 'eclass_locations': ('/mnt/portage/cvs',)}
> [DEBUG] options: {'include_dev': False, 'force': False, 'version': None,
> 'if_modified': 'n', 'commitmsg': None, 'ignore_arches': False, 'verbosity': 2,
> 'pretend': False, 'quiet': 0, 'xml_parse': False, 'ignore_masked': False,
> 'ignore_default_opts': None, 'vcs': None, 'mode': 'full', 'commitmsgfile':
> None, 'ask': False, 'without_mask': False, 'echangelog': 'y',
> 'unmatched_removal': False}

This is the output:

$ repoman -vv full
[DEBUG] repo config: {'disable_manifest': False, 'eclass_overrides': None, 'masters': (), 'sign_manifest': True, 'name': 'gentoo', 'format': None, 'user_location': '/home/pacho/gentoo-x86', 'eclass_locations': ('/home/pacho/gentoo-x86',), 'main_repo': None, 'allow_missing_manifest': False, 'sync': 'rsync://rsync.gentoo.org/gentoo-portage', 'priority': 4, 'cache_format': None, 'location': '/home/pacho/gentoo-x86', 'thin_manifest': False, 'create_manifest': True, 'manifest_hashes': None, 'update_changelog': False, 'missing_repo_name': False, 'aliases': None}
[DEBUG] options: {'include_dev': False, 'force': False, 'version': None, 'if_modified': 'n', 'commitmsg': None, 'ignore_arches': False, 'verbosity': 2, 'pretend': False, 'quiet': 0, 'xml_parse': False, 'ignore_masked': False, 'ignore_default_opts': None, 'vcs': None, 'mode': 'full', 'commitmsgfile': None, 'ask': False, 'without_mask': False, 'echangelog': None, 'unmatched_removal': False}
[INFO] Setting paths:
[INFO] PORTDIR = "/home/pacho/gentoo-x86"
[INFO] PORTDIR_OVERLAY = ""
[DEBUG] Found the following packages to scan:
dev-cpp/pangomm

RepoMan scours the neighborhood...
[INFO] checking package dev-cpp/pangomm
  dependency.unknown            4
   dev-cpp/pangomm/pangomm-2.28.2.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.3.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.4.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
   dev-cpp/pangomm/pangomm-2.28.5.ebuild: RDEPEND: !<dev-cpp/gtkmm-2.13:2.4
  changelog.ebuildadded         1
   dev-cpp/pangomm/pangomm-2.28.5.ebuild

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

Please fix these important QA issues first.
RepoMan sez: "Make your QA payment on time and you'll never see the likes of me."
Comment 12 Zac Medico gentoo-dev 2011-10-27 15:07:17 UTC
(In reply to comment #11)
> $ repoman -vv full
> [DEBUG] repo config: {'disable_manifest': False, 'eclass_overrides': None,
> 'masters': (), 'sign_manifest': True, 'name': 'gentoo', 'format': None,
> 'user_location': '/home/pacho/gentoo-x86', 'eclass_locations':
> ('/home/pacho/gentoo-x86',), 'main_repo': None, 'allow_missing_manifest':
> False, 'sync': 'rsync://rsync.gentoo.org/gentoo-portage', 'priority': 4,
> 'cache_format': None, 'location': '/home/pacho/gentoo-x86', 'thin_manifest':
> False, 'create_manifest': True, 'manifest_hashes': None, 'update_changelog':
> False, 'missing_repo_name': False, 'aliases': None}

Your debug output shows 'update_changelog': False, so apparently it's not seeing the 'update-changelog = true' setting in /home/pacho/gentoo-x86/metadata/layout.conf.

There have been some changes to the relevant repo config code in git. Can you try using repoman from a git checkout to see if it makes any difference? In order to do that, just clone portage.git and then set PYTHONPATH and PATH as describe here:

  http://www.gentoo.org/proj/en/portage/doc/testing.xml#doc_chap3
Comment 13 Pacho Ramos gentoo-dev 2011-10-27 20:31:06 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > $ repoman -vv full
> > [DEBUG] repo config: {'disable_manifest': False, 'eclass_overrides': None,
> > 'masters': (), 'sign_manifest': True, 'name': 'gentoo', 'format': None,
> > 'user_location': '/home/pacho/gentoo-x86', 'eclass_locations':
> > ('/home/pacho/gentoo-x86',), 'main_repo': None, 'allow_missing_manifest':
> > False, 'sync': 'rsync://rsync.gentoo.org/gentoo-portage', 'priority': 4,
> > 'cache_format': None, 'location': '/home/pacho/gentoo-x86', 'thin_manifest':
> > False, 'create_manifest': True, 'manifest_hashes': None, 'update_changelog':
> > False, 'missing_repo_name': False, 'aliases': None}
> 
> Your debug output shows 'update_changelog': False, so apparently it's not
> seeing the 'update-changelog = true' setting in
> /home/pacho/gentoo-x86/metadata/layout.conf.


Here was the problem, I checked my /usr/portage/metadata/layout.conf instead of my CVS tree one (that was outdated)

Sorry for the inconvenience :(

> 
> There have been some changes to the relevant repo config code in git. Can you
> try using repoman from a git checkout to see if it makes any difference? In
> order to do that, just clone portage.git and then set PYTHONPATH and PATH as
> describe here:
> 
>   http://www.gentoo.org/proj/en/portage/doc/testing.xml#doc_chap3
Comment 14 Zac Medico gentoo-dev 2011-10-27 20:42:20 UTC
At least I found this one bug (never released) in the process of investigation:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=15bf7c846d9437be76584e106d527f51a5af9d1e