Bug 388297 – games-fps/LsdlDoom-1.5 version bump (ebuild attached)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jess Haas 2011-10-24 06:25:10 UTC]

I just released version 1.5 of LsdlDoom and put together a new ebuild for it. The patches required for 1.4.4.4 have now been merged in to upstream and the SDL_Mixer code has been rewritten to use the proper API so music support via SDL_Mixer has now been enabled in the ebuild. I added USE flags for the packages various options and cleaned things up a bit.

I also renamed things so LsdlDoom and PrBoom should no longer conflict. I will submit a fix for the PrBoom ebuild to fix this on that end as well.

Reproducible: Always

[Comment 1 Jess Haas 2011-10-24 06:26:11 UTC]

Created attachment 290695 [details]
lsdldoom-1.5.ebuild

[Comment 2 Jess Haas 2011-10-24 06:26:39 UTC]

Created attachment 290697 [details]
metadata.xml

[Comment 3 Jess Haas 2011-10-24 06:27:13 UTC]

Created attachment 290699 [details]
1.5-gentoo-paths.patch

[Comment 4 Mr. Bones. (RETIRED) 2011-10-24 16:38:15 UTC]

Sure would be nice if these got fixed up:

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * l_video_trans.c:339:5: warning: dereferencing type-punned pointer will break strict-aliasing rules
 * l_video_trans.c:363:7: warning: dereferencing type-punned pointer will break strict-aliasing rules


 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * m_fixed.h:108:3: warning: implicit declaration of function 'abs'
 * m_fixed.h:108:3: warning: implicit declaration of function 'abs'


 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * qmus2mid.c:420:48: warning: array subscript is below array bounds

[Comment 5 Jess Haas 2011-10-24 17:44:08 UTC]

I don't get those errors. Any idea what I need to do to reproduce. I will look into fixing them.

[Comment 6 Mr. Bones. (RETIRED) 2011-10-24 18:06:53 UTC]

probably need a newer gcc.  I'm using 4.5.3 here.

for abs you have to include math.h

the buffer one is because the code doesn't check the return value of the reading function, which could be -1, which is then used as an array index.

[Comment 7 Mr. Bones. (RETIRED) 2011-10-24 18:07:39 UTC]

Actually, it looks like abs is in stdlib.h

[Comment 8 Jess Haas 2011-10-26 01:32:23 UTC]

Created attachment 290833 [details]
lsdldoom-1.5.ebuild

[Comment 9 Jess Haas 2011-10-26 01:36:17 UTC]

I fixed those warnings and updated the package upstream. Didn't bother bumping the version so make sure to delete the package in distfiles and delete and rebuild the manifest to try it. Also I updated the ebuild moving the wad depends to RDEPENDS.

[Comment 10 Mr. Bones. (RETIRED) 2011-10-26 17:15:44 UTC]

in portage.