Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 388213 - Detect LICENSE/COPYING files in ${ED}/usr/share/doc/${PF}/
Summary: Detect LICENSE/COPYING files in ${ED}/usr/share/doc/${PF}/
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-23 12:25 UTC by Tomáš Chvátal (RETIRED)
Modified: 2021-04-11 20:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Chvátal (RETIRED) gentoo-dev 2011-10-23 12:25:52 UTC
Portage should detect installed LICENSE/COPYING files and bail out if file like LICENSE or COPYING is found anywhere in the ED.

Possibly it should even die not just warn, but QA warning for starters is enough.
Comment 1 SpanKY gentoo-dev 2011-10-25 06:01:48 UTC
and if we aren't already, have repoman warn when those files are listed in dodoc and DOCS ...
Comment 2 Ulrich Müller gentoo-dev 2011-12-28 17:33:31 UTC
(In reply to comment #0)
> Portage should detect installed LICENSE/COPYING files and bail out if file
> like LICENSE or COPYING is found anywhere in the ED.
> 
> Possibly it should even die not just warn, but QA warning for starters is
> enough.

There are programs that expect COPYING in specific places. For example, Emacs has a command describe-copying (C-h C-c), and it's not worthwhile to maintain a patch only to suppress one small file.
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2011-12-28 19:03:14 UTC
(In reply to comment #2)
> There are programs that expect COPYING in specific places. For example, Emacs
> has a command describe-copying (C-h C-c), and it's not worthwhile to maintain a
> patch only to suppress one small file.

Well then at least warning... :)

Some auto information as I myself might not notice it on huge packages.
Comment 4 Ulrich Müller gentoo-dev 2021-04-11 19:16:29 UTC
No progress since 10 years (and the idea makes no sense, see comment #2).
Can we close this please?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-11 19:17:35 UTC
(In reply to Ulrich Müller from comment #4)
> No progress since 10 years (and the idea makes no sense, see comment #2).
> Can we close this please?

No, it makes sense, we'll just make it a warning and add a possible opt-out.
Comment 6 Ulrich Müller gentoo-dev 2021-04-11 19:47:17 UTC
(In reply to Sam James from comment #5)
> No, it makes sense, we'll just make it a warning and add a possible opt-out.

See comment #2, checking whole ${ED} makes no sense. There are programs that want to read COPYING from a specific location. There are also copies of GPL and FDL embedded in GNU Info files. Not sure how we would even detect these.

We could add a warning if a license file is found in /usr/share/doc/${PF}/. Then again, there are packages installing a LICEN[CS]E or README file there which describes licensing of the package and its files, without actually including any license text.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-11 20:00:14 UTC
(In reply to Ulrich Müller from comment #6)
> (In reply to Sam James from comment #5)
> > No, it makes sense, we'll just make it a warning and add a possible opt-out.
> 
> See comment #2, checking whole ${ED} makes no sense. There are programs that
> want to read COPYING from a specific location. There are also copies of GPL
> and FDL embedded in GNU Info files. Not sure how we would even detect these.

Agreed, beyond scope of an automated tool for now.

> 
> We could add a warning if a license file is found in /usr/share/doc/${PF}/.
> Then again, there are packages installing a LICEN[CS]E or README file there
> which describes licensing of the package and its files, without actually
> including any license text.

Sorry, I figured it was obvious we'd just check that specific directory. Agreed this is the right course. Let's fix the bug.