Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 388085 - [PATCH] net-misc/dahdi should use KBUILD_OUTPUT for detached kernel build directory
Summary: [PATCH] net-misc/dahdi should use KBUILD_OUTPUT for detached kernel build dir...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2011-10-22 06:44 UTC by Felix Tiede
Modified: 2011-10-31 14:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-misc/dahdi-2.5.0.1 patch to use KBUILD_OUTPUT (dahdi-2.5.0.1.patch,800 bytes, text/plain)
2011-10-22 06:44 UTC, Felix Tiede
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Tiede 2011-10-22 06:44:04 UTC
Created attachment 290499 [details]
net-misc/dahdi-2.5.0.1 patch to use KBUILD_OUTPUT

net-misc/dahdi-2.5.0.1 fails to compile when KBUILD_OUTPUT doesn't point to /usr/src/linux.

Using KSRC="${KBUILD_OUTPUT}" instead of KERNEL_DIR solved the problem for me. A patch for the ebuild is attached.
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2011-10-26 09:20:10 UTC
+*dahdi-2.5.0.2 (26 Oct 2011)
+
+  26 Oct 2011; Tony Vroon <chainsaw@gentoo.org> -dahdi-2.5.0.1.ebuild,
+  +dahdi-2.5.0.2.ebuild:
+  Revised patch to build against stable hardened sources. Now uses Junghanns
+  1.13 drivers instead of 1.11. Respect KBUILD_OUTPUT as per Felix Tiede in bug
+  #388085. Drop 2.5.0.1 from tree as it is unusable with the current stable
+  hardened kernel.
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2011-10-26 13:48:51 UTC
Immediate regression on the production system:

You do not appear to have the sources for the 2.6.39-hardened-r8 kernel installed.
make: *** [modules] Error 1

This assumes that you are building against the running kernel on the machine. Some of us like to build a new kernel, prepare our modules and then reboot once instead of twice.
This change will be backed out in 2.5.0.1-r1.
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2011-10-26 14:21:27 UTC
+*dahdi-2.5.0.2-r1 (26 Oct 2011)
+
+  26 Oct 2011; Tony Vroon <chainsaw@gentoo.org> -dahdi-2.5.0.2.ebuild,
+  +dahdi-2.5.0.2-r1.ebuild:
+  Back out KERNEL_DIR -> KBUILD_OUTPUT change which is a regression. This would
+  require a reboot into a new kernel before one can build DAHDI against it.
Comment 4 Csaba Tóth 2011-10-27 01:23:25 UTC
The change is not backed out.. -r1 still has KBUILD_OUTPUT instead of KERNEL_DIR!
Comment 5 Felix Tiede 2011-10-27 04:07:46 UTC
I've tried using KBUILD_OUTPUT with and without a dedicated kernel directory and leaving it blank while using /usr/src/linux to point to the new (compiled) kernel worked for me as well as setting KBUILD_OUTPUT to the new kernel without booting it.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-10-31 14:47:39 UTC
FWIW I fixed it in -r1 (without revbump) to use the KV_OUT_DIR variable instead, should cover all use cases. If not, feel free to re-CC me as well.