Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 387617 - net-im/kadu-0.10.1 version bump
Summary: net-im/kadu-0.10.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Maciej Mrozowski
URL: http://www.kadu.im/w/English:Download...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 00:22 UTC by Bartosz Brachaczek
Modified: 2011-10-19 19:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bartosz Brachaczek 2011-10-19 00:22:21 UTC
Sorry for this 0-day version bump but what I really want to say here is to inform about a squashed patch of buildsystem improvements that is hosted on kadu servers[1]. It replaces patches currently used by Gentoo and improves on them so that work around PLUGINS variable in the ebuild is not needed anymore. This was set to go into official 0.10.1 but most uptream devs didn't want to make changes to the buildsystem in a bugfix release, so it will officially land in 0.11.0.

Also homepage has officially changed to http://www.kadu.im.

[1] http://download.kadu.im/patches/0.10.1-buildsystem-improvements.patch
Comment 1 Maciej Mrozowski gentoo-dev 2011-10-19 18:23:45 UTC
 endif (APPLE)
 endmacro (kadu_source_subdirectories)
 
+set (KADU_INSTALLS_SDK TRUE)
 include (cmake/FindKadu.cmake)
 include_directories (${CMAKE_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/kadu-core ${QT_INCLUDES})

So... they took my patch and replaced CMake option with hardcoded variable. And called it buildsystem improvements.
You've got to be kidding me.
Comment 2 Bartosz Brachaczek 2011-10-19 18:43:31 UTC
(In reply to comment #1)
Please, read this patch with some understanding first if you want to complain. KADU_INSTALLS_SDK is a private variable that has to be set by plugins which install their own SDK. It is useful for those who build plugins outside of kadu-core sources so that plugins which install SDK have INSTALL_SDK option and those which don't install SDK, don't have such option as well. And yes, I call it a buildsystem improvement.
Comment 3 Maciej Mrozowski gentoo-dev 2011-10-19 19:07:15 UTC
Ok, it's not really hardcoding as option is defined elsewhere (in FindKadu.cmake), my bad.