Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 387375 - net-misc/quagga-0.99.20-r1 stable request
Summary: net-misc/quagga-0.99.20-r1 stable request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: http://lists.quagga.net/pipermail/qua...
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2011-10-17 07:37 UTC by Marcin Mirosław
Modified: 2012-07-08 19:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Mirosław 2011-10-17 07:37:21 UTC
There is memory leak in bgp daemon. Please add patch to quagga.

Reproducible: Always
Comment 1 Agostino Sarubbo gentoo-dev 2011-10-17 09:21:27 UTC
Diego, please remove vulnerable version from the tree. TIA.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-10-17 11:26:56 UTC
Uhm Ago, this seems to be unrelated? But yeah will remove them.

Marcin, can you tell me whether it's present in .20 as well?
Comment 3 Marcin Mirosław 2011-10-17 11:38:19 UTC
Diego, memory leak appears in .20, we've got two situations when OOM kill bgp daemon after quagga update. Then we find email on list and patch. So "remove vulnerable version" it's ok if:
a) "vulnerable" means <.20
and
b) memory leak will be fixed in .20
:)
Comment 4 Marcin Mirosław 2011-10-17 11:51:45 UTC
Suplement, version .19 is also affected: http://lists.quagga.net/pipermail/quagga-users/2011-October/012534.html
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-10-17 12:01:19 UTC
I don't care about .19 or anything < .20 ... but I'm not sure if quagga upstream fixed the issue in .20, and since I don't use BGP myself it is a bit difficult to be sure of it :|
Comment 6 Marcin Mirosław 2011-10-17 12:26:17 UTC
.20 _is_ affected.
Comment 7 Agostino Sarubbo gentoo-dev 2011-10-17 15:03:33 UTC
(In reply to comment #2)
> Uhm Ago, this seems to be unrelated? But yeah will remove them.
Yep, just a reminder, but you can remove all old ebuilds after stabilization of new .20-r1.

After consulting, this bug becomes a security bug.
Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-10-21 22:52:36 UTC
I've fixed this in .20-r1, sorry for the delay.

I've also added a new init script so please check if it works fine for you.
Comment 9 Tim Sammut (RETIRED) gentoo-dev 2011-10-22 01:37:43 UTC
(In reply to comment #8)
> I've fixed this in .20-r1, sorry for the delay.
> 
> I've also added a new init script so please check if it works fine for you.

Great, thank you (and no problem).

Arches, please test and mark stable *noting* Diego's request above:
=net-misc/quagga-0.99.20-r1
Target keywords : "alpha amd64 arm hppa ppc s390 sparc x86"
Comment 10 Ian Delaney (RETIRED) gentoo-dev 2011-10-22 16:29:02 UTC
amd64:

ok, not knowing what init script would be old and which new, I consulted the Changelog hot off the press from a sync.

"take the chance to merge the two init scripts, so that zebra is the only real script, and the rest are actually symlinks."

testuser@archtester ~/RCS $ qlist quagga | grep /etc/init.d
/etc/init.d/zebra
/etc/init.d/ripd
/etc/init.d/ospfd
/etc/init.d/bgpd
/etc/init.d/ripngd
/etc/init.d/ospf6d

testuser@archtester ~/RCS $ file /etc/init.d/ripd
/etc/init.d/ripd: a /sbin/runscript script, ASCII text executable
testuser@archtester ~/RCS $ file /etc/init.d/ospfd
/etc/init.d/ospfd: symbolic link to `ripd'
testuser@archtester ~/RCS $ file /etc/init.d/zebra
/etc/init.d/zebra: a /sbin/runscript script, ASCII text executable
testuser@archtester ~/RCS $ file /etc/init.d/bgpd
/etc/init.d/bgpd: symbolic link to `ripd'
testuser@archtester ~/RCS $ file /etc/init.d/ripngd
/etc/init.d/ripngd: symbolic link to `ripd'
testuser@archtester ~/RCS $ file /etc/init.d/ospf6d
/etc/init.d/ospf6d: symbolic link to `ripd'

Cal me pedantic, but the description does not match.  Technically /etc/init.d/ripd warrants a bug filing since it's not a symlink.  Be understanding of my reluctance and preference to await your opinion.

archtester xen-tools # /etc/init.d/zebra start
 * Cleaning up stale zebra routes... ...                                         [ ok ]
 * Starting zebra ...                                                            [ ok ]
archtester xen-tools # /etc/init.d/zebra stop
 * Stopping zebra ... 

  Testing of the remainder just requires making a copy of the conf files from   /usr/share/doc/quagga-0.99.20/samples/.  Is it required?
Comment 11 Elijah "Armageddon" El Lazkani (amd64 AT) 2011-10-22 19:05:51 UTC
amd64: emerge pass.
Comment 12 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-10-25 16:40:35 UTC
x86 stable
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2011-10-28 15:23:11 UTC
Stable for HPPA.
Comment 14 Markos Chandras (RETIRED) gentoo-dev 2011-10-29 10:37:07 UTC
amd64 done. Thanks Elijah and Ian
Comment 15 Markus Meier gentoo-dev 2011-11-01 05:46:31 UTC
arm stable
Comment 16 Alex Legler (RETIRED) archtester gentoo-dev Security 2011-11-01 10:17:45 UTC
This is not a security issue, as there is no way to trigger this, rather the leak occurs right after starting quagga.
Comment 17 Raúl Porcel (RETIRED) gentoo-dev 2011-12-18 17:55:36 UTC
alpha/s390/sparc stable
Comment 18 Michael Weber (RETIRED) gentoo-dev 2012-06-14 05:41:17 UTC
ppc stable, removing last arch.
Comment 19 Agostino Sarubbo gentoo-dev 2012-07-08 19:58:00 UTC
was not security issue