385273 – app-mobilephone/smstools does not respect CFLAGS

Bug 385273 - app-mobilephone/smstools does not respect CFLAGS

Summary: app-mobilephone/smstools does not respect CFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Tony Vroon (RETIRED)

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2011-10-01 23:40 UTC by Agostino Sarubbo
Modified:	2011-11-28 22:35 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
ebuild.patch (diff,2.17 KB, patch) 2011-10-01 23:40 UTC, Agostino Sarubbo	Details \| Diff
ebuild.patch (diff,1.83 KB, text/plain) 2011-11-28 22:24 UTC, Agostino Sarubbo	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Agostino Sarubbo gentoo-dev

2011-10-01 23:40:37 UTC

Created attachment 288479 [details, diff]
ebuild.patch

Tony, I remember you that it does not respect user cflags

See attached patch

Comment 1 Tony Vroon (RETIRED) gentoo-dev

2011-11-11 15:03:30 UTC

Please refrain from shuffling around whitespace or alphabetically sorting KEYWORDS. These are in chronological order, as they should be.
I require a list of what the improvements are.

Comment 2 Agostino Sarubbo gentoo-dev

2011-11-28 22:24:08 UTC

Created attachment 294105 [details]
ebuild.patch

-sort keywords
-readability
-added missing die
-cflags respect
-fowners/fperms replace

Comment 3 Tony Vroon (RETIRED) gentoo-dev

2011-11-28 22:35:46 UTC

+*smstools-3.1.14-r2 (28 Nov 2011)
+
+  28 Nov 2011; Tony Vroon <chainsaw@gentoo.org> +smstools-3.1.14-r2.ebuild:
+  CFLAGS respect & die statements by Agostino "ago" Sarubbo in bug #385273.

As discussed the KEYWORDS change is frivolous and has been undone. Thank you for your contribution.