Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 385167 - app-emacs/popwin-0.3 renders app-editors/emacs-vcs-24.0.90 unusable
Summary: app-emacs/popwin-0.3 renders app-editors/emacs-vcs-24.0.90 unusable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Naohiro Aota
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-01 10:25 UTC by Ulrich Müller
Modified: 2011-10-21 07:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2011-10-01 10:25:42 UTC
After emergeing app-emacs/popwin-0.3:

  1. Start emacs with "emacs-24 -q" from user's home directory
  2. Type C-x C-f
  3. At the ~/ prompt, press TAB twice for completion

This will result in an error "Variable binding depth exceeds max-specpdl-size".

With Emacs 23 the problem doesn't occur. However, as Emacs 24 is in pretest already, the bug needs to be fixed.


Furthermore, the package's site file has some problems:
  1. Don't call "require" or "load" as this increases Emacs's startup time.
  2. Don't redefine variables like display-buffer-function.
The guiding principle is that emerging a package should not change standard Emacs behaviour by itself.

IMHO, the site-init-file should just add the directory to the load-path and then autoload the relevant function:

(add-to-list 'load-path "@SITELISP@")
(autoload 'popwin:display-buffer "popwin"
  "Display BUFFER-OR-NAME, if possible, in a popup window, or as usual.
This function can be used as a value of `display-buffer-function'." t)
Comment 1 Naohiro Aota gentoo-dev 2011-10-21 07:45:15 UTC
Sorry for the late response and thanks for your fix.

I've added upstream Emacs24 support code as -r1.