Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 384945 - media-video/mplayer2-9999 should use media-libs/libbluray-9999
Summary: media-video/mplayer2-9999 should use media-libs/libbluray-9999
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 14:54 UTC by Alexander E. Patrakov
Modified: 2011-11-15 17:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander E. Patrakov 2011-09-29 14:54:35 UTC
If I emerge mplayer2 with the bluray USE flag on a system containing media-libs/libbluray-0.0.1_pre20110210-r1, it doesn't play blurays (doesn't decect the presence of the library). This happens because the prototype of bd_get_title_info() has changed: the header contains the declaration of this function with two arguments, while mplayer looks for a three-argument version, as in the git version of libbluray.

Reproducible: Always

Steps to Reproduce:
1. emerge =media-libs/libbluray-0.0.1_pre20110210-r1 =media-video/mplayer2-9999

Actual Results:  
mplayer2 doesn't play blurays

Expected Results:  
mplayer2 should play blurays

Declaration from libbluray-0.0.1_pre20110210-r1:

/**
 *
 *  Get information about a title
 *
 * @param bd  BLURAY object
 * @param title_idx title index number
 * @return allocated BLURAY_TITLE_INFO object, NULL on error
 */
BLURAY_TITLE_INFO* bd_get_title_info(BLURAY *bd, uint32_t title_idx);


Declaration from libbluray-9999:

/**
 *
 *  Get information about a title
 *
 * @param bd  BLURAY object
 * @param title_idx title index number
 * @param angle angle number (chapter offsets and clip size depend on selected angle)
 * @return allocated BLURAY_TITLE_INFO object, NULL on error
 */
BLURAY_TITLE_INFO* bd_get_title_info(BLURAY *bd, uint32_t title_idx, unsigned angle);

mplayer2-9999 configure script looks for this:

  statement_check libbluray/bluray.h 'bd_get_title_info(0, 0, 0)' -lbluray && _bluray=yes
Comment 1 Tim Harder gentoo-dev 2011-11-15 06:29:35 UTC
If you're using mplayer2-9999 then just use libbluray-9999 as well. I don't see why the ebuilds need to change just add the correct keywords to use both live versions.
Comment 2 Alexander E. Patrakov 2011-11-15 07:07:16 UTC
Fair enough. None of the existing -9999 ebuilds in media-video or media-sound declare a dependency on another -9999 ebuild, even though there are surely such dependencies in reality.
Comment 3 Steve Dibb (RETIRED) gentoo-dev 2011-11-15 17:33:12 UTC
(In reply to comment #1)
> If you're using mplayer2-9999 then just use libbluray-9999 as well. I don't see
> why the ebuilds need to change just add the correct keywords to use both live
> versions.

I kind of disagree.  I think it'd be a good idea to add them as a dependency, especially since, in this case, it won't even work without that release of libbluray.