Created attachment 288075 [details] [PATCH] Include expat.h using relative path chromium-9999-r1 needs to patch chrome/browser/autofill/autofill_xml_parser.h to compile (expat.h relative path error). I attached the patch that was previously used. I know epatch_user is used in the ebuild but it is dev oriented. Explicitely using epatch with this patch will allow any Gentoo user to compile chromium-9999 out of the box.
Please send this upstream. This is 9999, there is no point to patch this locally.
The patch was just something I was testing in my overlay. The chromium-9999-r1 ebuild in gentoo-x86 should not require the patch since we do not remove the contents of third_party/expat. Pawel indicated that it would be better to implement a shim header, and I just haven't gotten around to doing that.
I understand, I close the issue. I thought the process was to patch first from ebuild 9999 then to send patch upstream if working and applicable. To me, using epatch instead of epatch_user was a mean to share patches and test them widely before removing them from ebuild when applied upstream. Sometimes, I try to re-use the system libs and to remove bundled one, that was the reason of the failure here without the patch from Mike's overlay. Paweł, I'm not sure if I'm able to send good patch upstream for now (but I will try). I'm just applying and trying trivial fixes (often already fixed in Mike's overlay)
Reopen, I didn't see the issue title was changed.
Fixed in tree. It turns out this expat #include is not even needed.
