Compilation with libpng-1.5.5 fails for emacs-21.4-r23: gcc -O -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I. -I/var/tmp/portage/app-editors/emacs-21.4-r23/work/emacs-21.4/src -D_BSD_SOURCE -ggdb -O2 -pipe xfns.c xfns.c: In function ‘my_png_error’: xfns.c:8549:19: error: dereferencing pointer to incomplete type xfns.c: In function ‘png_load’: xfns.c:8707:7: error: dereferencing pointer to incomplete type make[1]: *** [xfns.o] Error 1 make[1]: Leaving directory `/var/tmp/portage/app-editors/emacs-21.4-r23/work/emacs-21.4/src' make: *** [src] Error 2 ... and for emacs-22.3-r8: gcc -O -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I. -I/var/tmp/portage/app-editors/emacs-22.3-r8/work/emacs-22.3/src -D_BSD_SOURCE -I/usr/include/alsa -march=core2 -ggdb -O2 -pipe image.c image.c: In function ‘my_png_error’: image.c:6430:19: error: dereferencing pointer to incomplete type image.c: In function ‘png_load’: image.c:6606:7: error: dereferencing pointer to incomplete type make[1]: *** [image.o] Error 1 make[1]: Leaving directory `/var/tmp/portage/app-editors/emacs-22.3-r8/work/emacs-22.3/src' make: *** [src] Error 2 USE flags are as follows: app-editors/emacs-21.4-r23 USE="X Xaw3d -leim -motif -sendmail" app-editors/emacs-22.3-r8 USE="X Xaw3d alsa gif jpeg png source tiff xpm -gtk -gzip-el -hesiod -kerberos -motif -sound -toolkit-scroll-bars"
Time for last rites for SLOTs 21 and 22, or should we backport the fix from Emacs 23?
<ssuominen> ulm: need patches for those slots? <ssuominen> don't want to waste time if they are getting lastrited, but ... <ssuominen> don't want emacs to become a bottleneck for libpng15 stabilization either. <ulm> ssuominen: I don't really intend to fix them <ulm> but let's wait for fauli's opinion on the matter <ssuominen> k <ulm> ssuominen: if we decide on fixing it, I think this is the patch that has to be backported: http://bzr.savannah.gnu.org/lh/emacs/emacs-23/revision/100432 <ssuominen> ulm: they seem to go through extra hoops for Windows build on that one, otherwise a 2-liner patch would solve the build problems, replacing png_ptr->jmpbuf with png_jmpbuf(png_ptr)
(In reply to comment #2) > a 2-liner patch would solve the build problems, replacing png_ptr->jmpbuf > with png_jmpbuf(png_ptr) Right, the patch is trivial: <http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/src/patchsets/emacs/22.3/10_all_libpng15.patch?view=markup> Therefore fixed, without revbump.