Bug 383441 – Ebuild proposal: dev-util/ninja-9999

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description mail 2011-09-18 02:58:35 UTC]

I wrote a ebuild for dev-util/ninja, which is originally developed by Evan Martine.
ninja is widely used by Chromium and Chromium OS developers as a faster replacement of gnu make.

Could you review this ebuild?

Reproducible: Always

[Comment 1 mail 2011-09-18 03:01:28 UTC]

Created attachment 286849 [details]
ebuild

[Comment 2 mail 2011-09-18 03:03:46 UTC]

Created attachment 286851 [details]
metadata

[Comment 3 mail 2011-09-18 07:21:05 UTC]

Created attachment 286857 [details, diff]
patch, including ebuild, metadata and patch in files/.

Adding source URL and prevent resetting CFLAGS and LDFLAGS.

[Comment 4 Naohiro Aota 2011-09-29 19:33:04 UTC]

Program binary seems fine.

Some suggestions:

- Since this is LIVEVCS ebuild, it would be better to drop all KEYWORDS (or try snapshot (like ninja-20110930.ebuild) instead)
- What's this elisp is for? for "*.ninja" files? then why don't you add site-gentoo file to autoload ninja-mode and set auto-mode-alist? (see app-emacs/xslide for example)

[Comment 5 Naohiro Aota 2012-05-28 15:39:15 UTC]

Modified for current git version and its release and added to betagarden overlay.

[Comment 6 Christoph Junghans (RETIRED) 2012-08-08 03:02:42 UTC]

I take it.