Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 38329 - The ctwm ebuild does not support XPM and therefore lacks standard icons
Summary: The ctwm ebuild does not support XPM and therefore lacks standard icons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Desktop WM Team (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-15 13:39 UTC by Raimo Niskanen
Modified: 2004-01-15 14:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raimo Niskanen 2004-01-15 13:39:56 UTC
When I emerge ctwm-3.6 it does not compile with XPM support, and the .xpm files that normally are included with a standard ctwm installation are simply not there even less installed in the right place.

Reproducible: Always
Steps to Reproduce:
1. emerge ctwm
2. start ctwm with a .ctwmrc file that sets an xpm directory and uses some .xpm buttons.
3.

Actual Results:  
Ctwm claims it does not find any .xpm files.

Expected Results:  
Found the .xmp files.

Sorry, the machine with gentoo linux is down at the moment, this is a Debin 3.0.

I did set severity: Enhancement, but I think it is an essential enhancement!
Comment 1 Raimo Niskanen 2004-01-15 13:44:54 UTC
Oh, and I have a patch.

I hope there are no licensing problems with the appended images, I have not checked it. Patch:
Only in /usr/portage/x11-wm/ctwm: ChangeLog
Only in /usr/portage/x11-wm/ctwm: Manifest
diff -cr usr/portage/x11-wm/ctwm/ctwm-3.6.ebuild /usr/portage/x11-wm/ctwm/ctwm-3
.6.ebuild
*** usr/portage/x11-wm/ctwm/ctwm-3.6.ebuild     Thu Jan  1 15:17:56 2004
--- /usr/portage/x11-wm/ctwm/ctwm-3.6.ebuild    Thu Jan  1 15:54:33 2004
***************
*** 7,13 ****
  S=${WORKDIR}/${P}
  DESCRIPTION="A clean, light window manager."
 
! SRC_URI="http://ctwm.free.lp.se/dist/${P}.tar.gz"
  HOMEPAGE="http://ctwm.free.lp.se/"
 
  SLOT="0"
--- 7,13 ----
  S=${WORKDIR}/${P}
  DESCRIPTION="A clean, light window manager."
 
! SRC_URI="http://ctwm.free.lp.se/dist/${P}.tar.gz http://ctwm.free.lp.se/dist/c
twm-images.tar.gz"
  HOMEPAGE="http://ctwm.free.lp.se/"
 
  SLOT="0"
***************
*** 17,24 ****
  DEPEND="virtual/x11"
 
  src_unpack() {
!       unpack ${A}
        cd ${S}
        epatch ${FILESDIR}/${P}-gentoo.diff
  }
 
--- 17,25 ----
  DEPEND="virtual/x11"
 
  src_unpack() {
!       unpack ${P}.tar.gz
        cd ${S}
+       unpack ctwm-images.tar.gz
        epatch ${FILESDIR}/${P}-gentoo.diff
  }
 
Only in usr/portage/x11-wm/ctwm: ctwm-3.6.ebuild.new
Only in /usr/portage/x11-wm/ctwm: ctwm-3.7_alpha4.ebuild
diff -cr usr/portage/x11-wm/ctwm/files/ctwm-3.6-gentoo.diff /usr/portage/x11-wm/
ctwm/files/ctwm-3.6-gentoo.diff
*** usr/portage/x11-wm/ctwm/files/ctwm-3.6-gentoo.diff  Thu Jan  1 15:13:51 2004
--- /usr/portage/x11-wm/ctwm/files/ctwm-3.6-gentoo.diff Thu Jan  1 15:41:17 2004
***************
*** 1,14 ****
- --- Imakefile-orig    2001-12-11 16:38:52.000000000 +0100
- +++ Imakefile 2003-05-08 14:22:20.000000000 +0200
- @@ -9,7 +9,7 @@
-  #undef  DEBUG
-  #undef  IMCONV
-  #undef  USE_SOUND
- -#define XPM
- +#undef XPM
-  #define USEM4
-  #undef X11R6
-  #undef I18N
  --- gram.y-orig       2001-12-11 16:38:52.000000000 +0100
  +++ gram.y    2003-05-08 13:11:55.000000000 +0200
  @@ -427,6 +427,7 @@
--- 1,3 ----
Only in /usr/portage/x11-wm/ctwm/files: ctwm-3.7_alpha4-gentoo.diff
Only in /usr/portage/x11-wm/ctwm/files: digest-ctwm-3.6
Only in /usr/portage/x11-wm/ctwm/files: digest-ctwm-3.7_alpha4
Only in /usr/portage/x11-wm/ctwm: metadata.xml
===end of patch

Note: in this patch a patch file is patched.

I could not download the ctwm_images.tar.gz file from the source in the patched script since he site was down, but I found it on a related site.

/Raimo Niskanen (aka ratmapper)
Comment 2 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-01-15 14:58:40 UTC
Fixed in CVS. Thanks for reporting!