Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 382961 - dev-tcltk/expect-5.45: build failed because of Gentoo patch
Summary: dev-tcltk/expect-5.45: build failed because of Gentoo patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All FreeBSD
: Normal normal (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 14:37 UTC by Naohiro Aota
Modified: 2011-11-04 12:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
complete build.log (build.log,45.05 KB, text/plain)
2011-09-14 14:39 UTC, Naohiro Aota
Details
new expect-5.45-headers.patch (expect-5.45-headers.patch,2.14 KB, patch)
2011-09-14 22:50 UTC, Naohiro Aota
Details | Diff
new expect-5.45-gfbsd.patch (expect-5.45-gfbsd.patch,996 bytes, patch)
2011-09-14 22:53 UTC, Naohiro Aota
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naohiro Aota gentoo-dev 2011-09-14 14:37:47 UTC
Failed because of missing pty.h like:

Dbg.c:698:2: warning: enumeration value 'down' not handled in switch
i686-gentoo-freebsd8.2-gcc -DPACKAGE_NAME=\"expect\" -DPACKAGE_TARNAME=\"expect\" -DPACKAGE_VERSION=\"5.45\" -DPACKAGE_STRING=\"expect\ 5.45\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DBUILD_expect=/\*\*/ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DNO_VALUES_H=1 -DHAVE_LIMITS_H=1 -DHAVE_SYS_PARAM_H=1 -DMODULE_SCOPE=extern\ __attribute__\(\(__visibility__\(\"hidden\"\)\)\) -DTCL_WIDE_INT_TYPE=long\ long -DUSE_TCL_STUBS=1 -DUSE_TCL_STUBS=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FCNTL_H=1 -DRETSIGTYPE=void -DHAVE_SYS_TIME_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_STRUCT_TM_TM_ZONE=1 -DHAVE_TM_ZONE=1 -DHAVE_GMTIME_R=1 -DHAVE_LOCALTIME_R=1 -DHAVE_TM_GMTOFF=1 -DNO_UNION_WAIT=1 -DHAVE_OPENPTY=1 -DHAVE_MEMMOVE=1 -DHAVE_SYSCONF=1 -DHAVE_STRFTIME=1 -DHAVE_STRCHR=1 -DHAVE_TIMEZONE=1 -DHAVE_SIGLONGJMP=1 -DHAVE_MEMCPY=1 -DWNOHANG_BACKUP_VALUE=1 -DSELECT_MASK_TYPE=fd_set -DHAVE_TCSETATTR=1 -DPOSIX=1 -DHAVE_TERMIOS=1 -DHAVE_TIOCGWINSZ_IN_TERMIOS_H=1 -DHAVE_SV_TIMEZONE=1 -DHAVE_LONG_FILE_NAMES=1 -DTCL_DEBUGGER -DUSE_NON_CONST -DSCRIPTDIR=\"/usr/lib/expect5.45\" -DEXECSCRIPTDIR=\"/usr/lib/expect5.45\" -DSTTY_BIN=\"/bin/stty\" -DDFLT_STTY="\"sane\"" -I. -I"." -I"/usr/lib/tcl8.5/include/generic" -I"/usr/lib/tcl8.5/include/unix"    -O2 -march=native -pipe -fomit-frame-pointer -pipe -O2 -Wall -fPIC  -c `echo pty_termios.c` -o pty_termios.o
pty_termios.c:13:17: fatal error: pty.h: No such file or directory
compilation terminated.
gmake: *** [pty_termios.o] Error 1

The line is originate from files/expect-5.45-headers.patch. We should improve the patch to detect "pty.h" is exist or not.
Comment 1 Naohiro Aota gentoo-dev 2011-09-14 14:39:02 UTC
Created attachment 286439 [details]
complete build.log
Comment 2 Naohiro Aota gentoo-dev 2011-09-14 22:50:58 UTC
Created attachment 286483 [details, diff]
new expect-5.45-headers.patch

tcltk herd,
Please review this new headers patch. It build fine both on FreeBSD and Linux.
This patch 

1. move #include <pty.h> into #ifdef HAVE_PTY_H ... #endif
2. introduce new #include <libutil.h> in #ifdef HAVE_LIBUTIL_H ... #endif
3. Add according AC_CHECK_HEADER to configure.in
Comment 3 Naohiro Aota gentoo-dev 2011-09-14 22:53:03 UTC
Created attachment 286485 [details, diff]
new expect-5.45-gfbsd.patch

Another patch to make it build on Gentoo/FreeBSD. We don't follow original FreeBSD's dot-stripped library versioning policy.
Comment 4 Naohiro Aota gentoo-dev 2011-11-04 11:52:57 UTC
ping. I'll update the patch in a week or two.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2011-11-04 12:41:23 UTC
+  04 Nov 2011; Justin Lecher <jlec@gentoo.org> files/expect-5.45-gfbsd.patch,
+  files/expect-5.45-headers.patch, metadata.xml:
+  Updated patches, thanks Naohiro Aotaf or this #382961
+