Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 382731 - media-gfx/exiv2 fails to build under et_EE locale
Summary: media-gfx/exiv2 fails to build under et_EE locale
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Stefan Briesenick (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 437432
  Show dependency tree
 
Reported: 2011-09-12 18:38 UTC by Priit Laes (IRC: plaes)
Modified: 2013-01-24 22:09 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
exiv2-0.23-r1.ebuild (exiv2-0.23-r1.ebuild,3.27 KB, application/octet-stream)
2012-10-15 18:40 UTC, Mario Kicherer
Details
exiv2-0.23-r1.ebuild (exiv2-0.23-r1.ebuild,3.25 KB, text/plain)
2012-10-16 09:32 UTC, Mario Kicherer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2011-09-12 18:38:38 UTC
exiv2's build scripts are using [A-Z] regexp which is known to break under
et_EE locale due to our peculiar alphabet letter ordering. This causes following build error:

[snip]
libtool: link: i686-pc-linux-gnu-g++ -Wl,-O1 -Wl,--as-needed -o .libs/taglist taglist.o  -L/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/xmpsdk/src ./.libs/libexiv2.so -Wl,-rpath -Wl,/usr/lib
libtool: link: i686-pc-linux-gnu-g++ -Wl,-O1 -Wl,--as-needed -o .libs/exiv2 exiv2.o actions.o utils.o  -L/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/xmpsdk/src ./.libs/libexiv2.so -Wl,-rpath -Wl,/usr/lib
taglist.o: In function `main':
/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/src/taglist.cpp:36: undefined reference to `Exiv2::IptcDataSets::dataSetList(std::basic_ostream<char, std::char_traits<char> >&)'
/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/src/taglist.cpp:55: undefined reference to `Exiv2::ExifTags::taglist(std::basic_ostream<char, std::char_traits<char> >&)'
/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/src/taglist.cpp:31: undefined reference to `Exiv2::ExifTags::taglist(std::basic_ostream<char, std::char_traits<char> >&)'
/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/src/taglist.cpp:40: undefined reference to `Exiv2::ExifTags::isExifGroup(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/src/taglist.cpp:41: undefined reference to `Exiv2::ExifTags::taglist(std::basic_ostream<char, std::char_traits<char> >&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/src/taglist.cpp:40: undefined reference to `Exiv2::ExifTags::isMakerGroup(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/var/tmp/portage/media-gfx/exiv2-0.21.1-r2/work/exiv2-0.21.1/src/taglist.cpp:46: undefined reference to `Exiv2::XmpProperties::printProperties(std::basic_ostream<char, std::char_traits<char> >&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
taglist.o:(.gcc_except_table+0x48): undefined reference to `typeinfo for Exiv2::AnyError'
[/snip]



Portage 2.2.0_alpha55 (default/linux/x86/10.0, gcc-4.5.3, glibc-2.13-r4, 3.1.0-rc3+ i686)
=================================================================
System uname: Linux-3.1.0-rc3+-i686-Intel-R-_Pentium-R-_M_processor_1.60GHz-with-gentoo-2.0.3
Timestamp of tree: Mon, 12 Sep 2011 17:00:01 +0000
app-shells/bash:          4.2_p10
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.2-r2, 3.2-r2
dev-util/cmake:           2.8.5-r2
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.9.3-r1
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r2, 1.10.3, 1.11.1-r1
sys-devel/binutils:       2.21.1-r1
sys-devel/gcc:            4.5.3-r1
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 2.6.39 (virtual/os-headers)
sys-libs/glibc:           2.13-r4
Repositories: gentoo science esteid
Installed sets: 
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="* RTCW-EULA"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -mtune=pentium-m -pipe -ggdb"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -mtune=pentium-m -pipe -ggdb"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs collision-protect distlocks ebuild-locks fixlafiles fixpackages news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="et_EE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/science /home/plaes/code/gentoo/esteid"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aac acpi alsa apng autoipd avahi berkdb bluetooth branding bzip2 cairo cdr cleartype cli consolekit cracklib crypt cxx daap dbus dell dri dvd exif fam ffmpeg flac fontconfig gdbm gnome gnome-keyring gnutls gphoto2 gstreamer gtk iconv idn jabber jpeg lame laptop latex libffi libnotify mmx modules mp3 msn mudflap nautilus ncurses network-cron networkmanager nls nptl nptlonly nsplugin ogg opengl openmp pam pcre png policykit pppd python readline session sip sse sse2 ssl startup-notification svg sysfs tcpd theora thunar tiff truetype udev unicode upnp usb v4l2 vorbis weather webkit x86 xcb xetex xml xmp xorg xv zeroconf zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="radeon r300" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Priit Laes (IRC: plaes) 2011-09-12 18:41:21 UTC
Fix can be done on line 233 in src/Makefile by prepending LC_ALL=C to the command:

-    sed 's/#define \([A-Z]\)/#define EXV_\1/; s/#undef \([A-Z]\)/#undef EXV_\1/' < $< > $@
+    LC_ALL=C sed 's/#define \([A-Z]\)/#define EXV_\1/; s/#undef \([A-Z]\)/#undef EXV_\1/' < $< > $@
Comment 2 Stefan Briesenick (RETIRED) gentoo-dev 2012-06-24 21:40:50 UTC
please test with media-gfx/exiv2-0.23.
Comment 3 Stefan Briesenick (RETIRED) gentoo-dev 2012-06-24 21:41:17 UTC
and btw: please report this issue also upstream.
Comment 4 Priit Laes (IRC: plaes) 2012-06-29 18:53:22 UTC
(In reply to comment #2)
> please test with media-gfx/exiv2-0.23.

Of course it fails with 0.23 :S
Comment 5 Mario Kicherer 2012-10-15 18:40:07 UTC
Created attachment 326636 [details]
exiv2-0.23-r1.ebuild

Could you please test this ebuild?

It adds the following lines to the ebuild:

+       # replace regexp with portable version regarding
+       # internationalization (bug #382731)
+       sed -i -r "s,\[A-Z\],\[\[:upper:\]\],g" src/Makefile

This is the last blocker for stabilization of 0.23, see bug #437432.
Comment 6 Priit Laes (IRC: plaes) 2012-10-16 07:56:03 UTC
(In reply to comment #5)
> Created attachment 326636 [details]
> exiv2-0.23-r1.ebuild
> 
> Could you please test this ebuild?
> 
> It adds the following lines to the ebuild:
> 
> +       # replace regexp with portable version regarding
> +       # internationalization (bug #382731)
> +       sed -i -r "s,\[A-Z\],\[\[:upper:\]\],g" src/Makefile
> 
> This is the last blocker for stabilization of 0.23, see bug #437432.

While it certainly works for et_EE locale, the [:upper:] range itself depends on the locale too.

Here's how it was fixed in kernel: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=f2dbe03dccc95f41429d60e4221b02fc0f112cc4
Comment 7 Mario Kicherer 2012-10-16 09:32:53 UTC
Created attachment 326686 [details]
exiv2-0.23-r1.ebuild

Oh okay. I modified the ebuild. Can you confirm that the ebuild works this way?
Comment 8 Priit Laes (IRC: plaes) 2012-10-17 07:55:56 UTC
(In reply to comment #7)
> Created attachment 326686 [details]
> exiv2-0.23-r1.ebuild
> 
> Oh okay. I modified the ebuild. Can you confirm that the ebuild works this
> way?

Yes, looks fine and works fine.
Comment 9 Mario Kicherer 2012-10-17 09:14:40 UTC
Excellent, thank you!

Now, stabilization of exiv2-0.23 should be possible in bug #437432.
Comment 10 Stefan Briesenick (RETIRED) gentoo-dev 2013-01-24 22:09:31 UTC
fixed in latest revbump.