Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 382587 - sys-boot/grub-1.99-r2 : better configuration through grub-mkconfig
Summary: sys-boot/grub-1.99-r2 : better configuration through grub-mkconfig
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-11 12:05 UTC by Rodolfo
Modified: 2012-06-29 02:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
patch (better-config.patch,1.50 KB, text/plain)
2011-09-11 12:05 UTC, Rodolfo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rodolfo 2011-09-11 12:05:21 UTC 
Created attachment 286119 [details]
patch

I created a patch to add 2 config options that go in /etc/default/grub:

GRUB_COLOR_NORMAL
GRUB_COLOR_HIGH

to set grub text color

I also provide a different fix for the GRUB_DISTRIBUTOR variable: the one provided in the ebuild doesn't work (missing export), and if it worked it would make impossible to change the variable via /etc/default/grub, so I patched 10_linux directly
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2011-09-14 17:45:55 UTC 
Is this patch in the upstream version? Eg in the bazaar repozitory?
I preffer to do changes like this only if they were approved by the upstream.
Comment 2 Rodolfo 2011-09-14 18:39:17 UTC 
(In reply to comment #1)
> Is this patch in the upstream version? Eg in the bazaar repozitory?
> I preffer to do changes like this only if they were approved by the upstream.

No they aren't :(, however I only patched (minimally) the grub.d scripts.

Anyway the GRUB_DISTRIBUTOR is actually a fix to what the ebuild is already trying to accomplish.
Comment 3 Mike Gilbert gentoo-dev 2012-06-29 02:38:26 UTC 
I'm not accepting patches for new features; this packages is complex enough. Submit it upstream if you wish.