Bug 382083 – net-misc/remmina-plugins-0.9.2-r1 missing deps for vnc use flag

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexander Kozyrev 2011-09-06 20:59:59 UTC]

To compile vnc protocol plugin remmina-plugins requires libvncserver, gnutls, jpeg and zlib to be installed. All dependencies except libvncserver haven't been set in the ebuild.

Reproducible: Always

[Comment 1 Alexander Kozyrev 2011-09-06 21:01:24 UTC]

Created attachment 285725 [details]
remmina-plugins-0.9.2-r2.ebuild

[Comment 2 Alexander Kozyrev 2011-09-06 21:03:11 UTC]

Created attachment 285727 [details, diff]
remmina-plugins-0.9.2-r1.patch

fixed ebuild and patch to the current one are attached

[Comment 3 Daniel M. Weeks 2011-09-07 22:31:25 UTC]

Did you run into a problem that led to this conclusion? From my research:

jpeg and zlib will both be pulled in with the appropriate use flags on libvncserver.

Also, in the latest version of libvncserver, I can't find any absolute dependence on GnuTLS. It looks like you can use it as an SSL library but it's not required.

I know the remmina website claims these 3 dependencies but this change certainly isn't necessary for this ebuild unless there is a problem. If GnuTLS really is required then I would think the change should be made to the libvncserver ebuild.

[Comment 4 Alexander Kozyrev 2011-09-08 08:33:57 UTC]

(In reply to comment #3)
> Did you run into a problem that led to this conclusion? From my research:
> 
> jpeg and zlib will both be pulled in with the appropriate use flags on
> libvncserver.
>
> Also, in the latest version of libvncserver, I can't find any absolute
> dependence on GnuTLS. It looks like you can use it as an SSL library but it's
> not required.
> 
> I know the remmina website claims these 3 dependencies but this change
> certainly isn't necessary for this ebuild unless there is a problem. If GnuTLS
> really is required then I would think the change should be made to the
> libvncserver ebuild.
When i emerged remmina-plugins-0.9.2-r1 i didn't get ability to connect via VNC in remmina. That was the reason i started investigation. I noticed vnc plugin didn't really compile, so i looked into configure.ac to see the real dependencies  the plugin requires. configure.ac stated that the plugin requires libvncclient (it seems that lib is supplied by net-libs/libvncserver), jpeg, zlib and gnutls >= 2.4.0. Not all required dependencies was reflected in the ebuild. And that's why i added gnutls, zlib and jpeg.
I have just checked libvncserver-0.9.7 ebuild and have found out it indeed includes zlib and jpeg as dependencies. So i find making remmina-plugins[vnc] dependent on libvncserver[zlib,jpeg] and gnutls instead of having libvncserver, jpeg, zlib and gnutls as separate dependecies rational.

[Comment 5 Alexander Kozyrev 2011-09-08 09:00:34 UTC]

Created attachment 285833 [details]
jpeg and zlib, deps declared via correspondent libvncserver use-flags

[Comment 6 Alexander Kozyrev 2011-09-08 09:01:01 UTC]

Created attachment 285835 [details, diff]
patch from r1 to r3

[Comment 7 Daniel M. Weeks 2011-09-09 02:58:40 UTC]

Ah I see where the requirement comes in now. Good find. I can fully agree with the changes you made in the newest revision you posted.

[Comment 8 Markos Chandras (RETIRED) 2011-09-30 17:39:34 UTC]

Thanks. Committed. Sorry it took me so long to respond