Specifically the main problem is that /usr/bin/deluge-gtk is still installed when the gtk use flag is disabled.
Hmm, this is annoying. There seems to be no way in the build system to disable gtk?
My plan to "solve" this is to remove "gtk" USE flag and install everything unconditionally. Any objections?
(In reply to Paolo Pedroni from comment #2) > My plan to "solve" this is to remove "gtk" USE flag and install everything > unconditionally. Any objections? Yes. I, for one, don't want GTK on a headless device. It'd be probably too much hacking to prevent it from building, but it's easy to do it like debian does - simply prevent incriminating files from installing. Also please note that it doesn't affect just deluge-gtk, but deluge-web, deluge-console and deluged as well. Every component should be optional, but at least one selected.
(In reply to Jan Chren (rindeal) from comment #3) > (In reply to Paolo Pedroni from comment #2) > > My plan to "solve" this is to remove "gtk" USE flag and install everything > > unconditionally. Any objections? > Yes. I, for one, don't want GTK on a headless device. > > It'd be probably too much hacking to prevent it from building, but it's easy > to do it like debian does - simply prevent incriminating files from > installing. > > Also please note that it doesn't affect just deluge-gtk, but deluge-web, > deluge-console and deluged as well. Every component should be optional, but > at least one selected. I'll take a look at the Debian Package, then, and I'll see if it easy to implement, but it's going to take some time.
(In reply to Paolo Pedroni from comment #4) > (In reply to Jan Chren (rindeal) from comment #3) > > (In reply to Paolo Pedroni from comment #2) > > > My plan to "solve" this is to remove "gtk" USE flag and install everything > > > unconditionally. Any objections? > > Yes. I, for one, don't want GTK on a headless device. > > > > It'd be probably too much hacking to prevent it from building, but it's easy > > to do it like debian does - simply prevent incriminating files from > > installing. > > > > Also please note that it doesn't affect just deluge-gtk, but deluge-web, > > deluge-console and deluged as well. Every component should be optional, but > > at least one selected. > > I'll take a look at the Debian Package, then, and I'll see if it easy to > implement, but it's going to take some time. In Debian, everything is built and different sets of files are packaged into different packages.
(In reply to Benda Xu from comment #5) > In Debian, everything is built and different sets of files are packaged into > different packages. I know. I meant that I'd look into the Debian package and see how it's split up and see if I can replicate that in the gentoo ebuild. Thanks for the feedback, anyway. :)
Created attachment 428612 [details, diff] deluge.patch Sample ebuild implementing this: https://github.com/rindeal/gentoo-overlay/blob/master/net-p2p/deluge/deluge-1.3.12-r4.ebuild There are more changes in my overlay, but probably only python_install_all() and *DEPEND will interest you.
(In reply to Jan Chren (rindeal) from comment #7) > Created attachment 428612 [details, diff] [details, diff] > deluge.patch > > Sample ebuild implementing this: > https://github.com/rindeal/gentoo-overlay/blob/master/net-p2p/deluge/deluge- > 1.3.12-r4.ebuild > > There are more changes in my overlay, but probably only python_install_all() > and *DEPEND will interest you. Thanks for your patch. I had already written something similar on my own, but yours looks better, and I'll sure much of your patch. I'm currently waiting to see bug #576910 solved before I commit anything more.
*** Bug 578074 has been marked as a duplicate of this bug. ***
Created attachment 436008 [details, diff] deluge-fix-bug-381837 This patch adds support for selection of installed UIs (plus a few miscellaneous fixes), adds a "stable" live ebuild and fixes development live ebuild. I took the liberty to add k_f@gentoo.org to the bug and I invite him to merge this to the portage tree as discussed in github PR #1324.
Created attachment 436010 [details, diff] deluge-remove-old.patch This patch removes version 1.3.12-r3, which is not needed anymore.
(In reply to Paolo Pedroni from comment #10) > I took the liberty to add k_f@gentoo.org to the bug and I invite him to > merge this to the portage tree as discussed in github PR #1324. Smart move :)
Created attachment 437828 [details, diff] deluge-fix-bug-381837.patch Here we go! First of the revised patches.
Created attachment 437830 [details, diff] deluge-remove-old.patch Second patch: remove old -r3 ebuild
Created attachment 437832 [details, diff] deluge-sync-live-ebuild.patch Third patch: sync live ebuild to latest fixes.
Created attachment 437834 [details, diff] deluge-add-stable-live-ebuild.patch Fourth patch: add stable live ebuild
Created attachment 438084 [details, diff] 0001-net-p2p-deluge-Make-UI-installation-USE-conditional.patch First patch, reformatted as per k_f request.
Created attachment 438086 [details, diff] 0002-net-p2p-deluge-Remove-old.patch Second patch, reformatted as per k_f request
Created attachment 438088 [details, diff] 0003-net-p2p-deluge-Sync-live-ebuild-to-latest-changes.patch Third patch, reformatted as per k_f request
Created attachment 438090 [details, diff] 0004-net-p2p-deluge-Add-stable-live-ebuild.patch Fourth patch, reformatted as per k_f request
Fixed in net-p2p/deluge-1.3.12-r4. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=406fd0f543d40c4dc292704883d0b2304d312bf1
