Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 381811 - www-client/firefox add minimal USE flag for optional sdk installation
Summary: www-client/firefox add minimal USE flag for optional sdk installation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2011-09-04 18:43 UTC by Nikoli
Modified: 2012-02-12 23:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
remove sdk from firefox and thunderbird with minimal useflag enabled (remove-sdk-thunderbird-firefox.patch,1.88 KB, patch)
2012-02-10 04:24 UTC, Jory A. Pratt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2011-09-04 18:43:54 UTC
$ equery s www-client/firefox
 * www-client/firefox-6.0
         Total files : 3779
         Total size  : 86.27 MiB
$ cat /etc/portage/env/www-client/firefox 
INSTALL_MASK="${INSTALL_MASK}
/usr/include
/usr/lib64/firefox/idl
/usr/lib64/firefox/include
/usr/lib64/firefox/lib
/usr/lib64/firefox/sdk
"
$ emerge -1vk firefox
$ equery s firefox
 * www-client/firefox-6.0
         Total files : 353
         Total size  : 33.45 MiB

Firefox does not need sdk at runtime, you can check with 'strace -fe open -o ~/logfile.txt firefox' and lsof. Also debian and ubuntu do not install this files as part of firefox package:
http://packages.debian.org/sid/amd64/iceweasel/filelist
http://packages.ubuntu.com/natty-updates/amd64/firefox/filelist
http://packages.ubuntu.com/natty-updates/amd64/firefox-dev/filelist

Please disable installation of sdk by default.
Comment 1 Rafał Mużyło 2011-09-04 19:19:42 UTC
Actually, it seems to be a good point to once again ask why exactly are we installing libxul twice.

I do remember Anarchy saying it's on purpose, but is it really a good purpose ?
Comment 2 Jory A. Pratt gentoo-dev 2011-09-04 19:45:16 UTC
(In reply to comment #1)
> Actually, it seems to be a good point to once again ask why exactly are we
> installing libxul twice.
> 
> I do remember Anarchy saying it's on purpose, but is it really a good purpose ?

your not installing it twice, firefox no longer makes use of system xulrunner which is depreciated.
Comment 3 Nikoli 2011-09-04 20:05:36 UTC
>your not installing it twice
Are you sure?
/usr/lib64/firefox/libmozalloc.so
/usr/lib64/firefox/sdk/lib/libmozalloc.so
/usr/lib64/firefox/libxpcom.so
/usr/lib64/firefox/sdk/lib/libxpcom.so
/usr/lib64/firefox/libxul.so
/usr/lib64/firefox/sdk/lib/libxul.so

Check this files with 'du -s'
Comment 4 Jory A. Pratt gentoo-dev 2011-09-04 20:41:27 UTC
Yes a copy of the file is placed in the sdk as well. Like always you the users want to compare gentoo to every other distro. If they were to build xulrunner-6.0.2 you would expect it for gentoo even tho it is rather useless these days with no system gre. If you all would like I can step down as the mozilla lead and let another member of the team take over.
Comment 5 Nikoli 2011-09-04 20:57:03 UTC
I asked to make package 2,6 times smaller, ubuntu was just used as proof of possibility.
Is there any technical problem with adding sdk(minimal) USE flag?
Comment 6 Rafał Mużyło 2011-09-05 11:46:57 UTC
Please, don't make it personal.

My point was that I'm quite aware that mozilla's build system is quite crazy in several places and so if both of the copies are identical (and not by chance either), it made a lot more sense to add a quirk to the build system than to install them twice.
It would be probably much less than what we're doing to i.e. boost.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-09-13 11:45:13 UTC

*** This bug has been marked as a duplicate of bug 381151 ***
Comment 8 Nikoli 2011-09-13 12:04:35 UTC
This bug is not duplicate of bug 381151, possibly it depends on it.

#gentoo-desktop irc:
[15:58:53] <Nikoli> nirbheek, do you think your new package (www-plugins/nsplugin-headers) will make size of firefox package 2,6 times smaller?
...
[15:59:53] <nirbheek> Nikoli, no, the aim of that package is to allow plugins to be compiled for other browsers
Comment 9 Jory A. Pratt gentoo-dev 2011-09-13 13:45:10 UTC
(In reply to comment #8)
> This bug is not duplicate of bug 381151, possibly it depends on it.
> 
> #gentoo-desktop irc:
> [15:58:53] <Nikoli> nirbheek, do you think your new package
> (www-plugins/nsplugin-headers) will make size of firefox package 2,6 times
> smaller?
> ...
> [15:59:53] <nirbheek> Nikoli, no, the aim of that package is to allow plugins
> to be compiled for other browsers

I still do not see what you expect to gain other then disk space. You are still gonna have to have the complete compile. I personally am not in favor of breaking the package apart as ubuntu and debian and others do.
Comment 10 Jory A. Pratt gentoo-dev 2011-12-19 03:15:44 UTC
I have actually thought about this much more and I do not see a point in keeping the sdk period. I have made a decision to remove all non-essential files unless the needs arises to revert the sdk install for both firefox and thunderbird.
Comment 11 Nikoli 2011-12-19 06:30:45 UTC
Do you plan to make changes in eclass and also affect thunderbird, icecat and other mozilla related packages?
Comment 12 Nirbheek Chauhan (RETIRED) gentoo-dev 2012-01-03 19:24:09 UTC
(In reply to comment #10)
> I have actually thought about this much more and I do not see a point in
> keeping the sdk period. I have made a decision to remove all non-essential
> files unless the needs arises to revert the sdk install for both firefox and
> thunderbird.

If we're going to remove the sdk libraries, we should also remove the headers which should avoid another 30MB of useless files.
Comment 13 Jory A. Pratt gentoo-dev 2012-02-10 04:24:26 UTC
Created attachment 301443 [details, diff]
remove sdk from firefox and thunderbird with minimal useflag enabled

Please comment as soon as possible, we will be looking to land this with the 10.0.1 release.
Comment 14 Nikoli 2012-02-10 05:40:55 UTC
Patch seems good. May be you also want to add custom USE description to metadata.xml? Something like "Remove SDK and headers".
Comment 15 Jory A. Pratt gentoo-dev 2012-02-12 23:04:20 UTC
{Firefox,Thunderbird}-10.0.1 are in the tree with minimal useflag enabled by default.