Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 381689 - dev-python/imaging-1.1.7 has hidden optional dependency on lcms
Summary: dev-python/imaging-1.1.7 has hidden optional dependency on lcms
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-03 13:02 UTC by Chris Mayo
Modified: 2012-01-06 22:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to ebuild (imaging-1.1.7.ebuild-lcms.patch,842 bytes, patch)
2011-09-04 10:26 UTC, Chris Mayo
Details | Diff
patch to setup.py (imaging-1.1.7-nolcms.patch,485 bytes, patch)
2011-09-04 10:26 UTC, Chris Mayo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2011-09-03 13:02:43 UTC
imaging-1.1.7 will build with lcms support if it finds lcms installed itself.

From setup.py:
        if find_include_file(self, "lcms.h"):
            if find_library_file(self, "lcms"):
                feature.lcms = "lcms"

Suggest adding a lcms USE flag with a dependency (appears to be media-libs/lcms:0) to make this clear. Obviously that wouldn't fix the (unlikely) situation that you had lcms installed but didn't want PIL to support it.
Comment 1 Chris Mayo 2011-09-04 10:26:27 UTC
Created attachment 285501 [details, diff]
patch to ebuild

Add lcms USE flag and disable _imagingcms.so creation if -lcms.
Comment 2 Chris Mayo 2011-09-04 10:26:45 UTC
Created attachment 285503 [details, diff]
patch to setup.py
Comment 3 Maxim Koltsov (RETIRED) gentoo-dev 2011-12-21 07:32:54 UTC
Patch applied, thanks
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-12-21 12:46:59 UTC
PIL/_imagingcms.so directly uses liblcms.so.1, not Python bindings of media-libs/lcms:0.
Comment 5 Chris Mayo 2011-12-23 15:49:00 UTC
Reopened for Arfrever's comment 4.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2012-01-06 22:30:56 UTC
This is now fixed