Way back, to close bug 21325, it was decided to replace "make test || die" with "make test" in the mod_perl ebuilds. I don't believe that is the correct thing to do. The problem reported in bug 21325 was an isolated instance and would have been solved easily by upgrading CGI.pm (perhaps we should have a dependency on a recent enough CGI, e.g., dev-perl/CGI-3.00) as I found out by searching the mod_perl mailing list archives at: http://marc.theaimsgroup.com/?l=apache-modperl&m=105950845107150&w=2 May be, it's time to add the "|| die" back in and let the tests be used for their real purpose (to tell the user when something doesn't pass 100%) rather than masking the problem and having people installed broken mod_perls. Comments? Can you work on adding a dependency for a recent enough dev-perl/CGI?
Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/apache/subprocess.t 4 1 25.00% 2 t/modules/cgi.t 5 1 20.00% 3 t/modules/cgi2.t 5 1 20.00% 3 t/modules/cgiupload.t 2 2 100.00% 1-2 t/modules/cgiupload2.t 2 2 100.00% 1-2 Failed 5/209 test scripts, 97.61% okay. 7/2975 subtests failed, 99.76% okay. So all we have to do is fixe those 2. i think the last 4 have to do with CGI.pm (not sure)
that was with CGI 3.05 here's with 2.93: t/apache/subprocess.t 4 1 25.00% 2 t/modules/cgi.t 5 1 20.00% 3 t/modules/cgiupload.t 2 2 100.00% 1-2 5 tests skipped. Failed 3/209 test scripts, 98.56% okay. 4/2962 subtests failed, 99.86% okay. so less b0rkage .. i'm beginning to suspend CGI doesnt handle URL escaped codes..
Re-assign.
discussed and resolved. make test || die doesn't work in mod_perl because of how the tests are being called.
