Bug 380711 – virtual/ruby-test-unit-0-r3 have needless dependency on ruby19

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Shunsuke Shimizu 2011-08-26 05:59:31 UTC]

Because there is test-unit-1.x compatible test API implemented by minitest bundled in ruby 1.9.x, the depend to dev-ruby/test-unit:0 is needless.

In addition, even if dev-ruby/test-unit:0 is installed, bundled test/unit compatible API is loaded when you require test/unit in ruby script. To require test-unit-1.2.3, you need to explicitly require from gem.

I tested all ebuilds which require virtual/ruby-test-unit for test on ruby19 without dev-ruby/test-unit:0. No ebuilds failed to test due to rack of test-unit-1.2.3, though some ebuilds failed to test (almost all failures of tests have been already reported).


emerge --info

Portage 2.2.0_alpha51 (default/linux/amd64/10.0/desktop/kde, gcc-4.4.5, glibc-2.13-r4, 3.0.3-gentoo x86_64)
=================================================================
System uname: Linux-3.0.3-gentoo-x86_64-AMD_Phenom-tm-_II_X4_920_Processor-with-gentoo-2.0.3
Timestamp of tree: Thu, 25 Aug 2011 10:30:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          4.2_p10
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.2-r2, 3.2-r2
dev-util/cmake:           2.8.5-r2
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.0.3
sys-apps/openrc:          0.8.3-r1
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:       2.21.1
sys-devel/gcc:            4.4.5
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r1
sys-kernel/linux-headers: 2.6.39 (virtual/os-headers)
sys-libs/glibc:           2.13-r4
Repositories: gentoo gentoo-haskell matsuu naota d-overlay grafi
Installed sets: 
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks ebuild-locks fixlafiles fixpackages news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="ja_JP.UTF-8"
LC_ALL="ja_JP.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="ja en"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/haskell /var/lib/layman/matsuu /var/lib/layman/naota /var/lib/layman/d /home/shunsuke/portage-overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cjk cli consolekit cracklib crypt cue cups cvs cxx dbus declarative djvu dri dts dvd dvdr eb emacs emboss encode exif faac faad fam firefox flac fontconfig fortran gdbm gdu gif git gnutls ibus iconv icu ipafont ipv6 java java6 jpeg jpeg2k kde kipi kpathsea lcms ldap libnotify lzma m17nlib mad mercurial migemo mmx mmxext mng modules mono mozc mp3 mp4 mpeg mudflap multilib ncurses nls nptl nptlonly nsplugin ogg opengl openmp pam pango pcre pdf pdflatex perl phonon plasma png policykit ppds pppd python qt qt3support qt4 readline ruby sasl sdl semantic-desktop session spell sqlite sse sse2 ssl ssse3 startup-notification subversion svg sysfs syslog tcpd theora threads tiff tk truetype udev unicode usb vim vim-pager vim-syntax vim-with-x vorbis wavpack x264 xcb xcomposite xetex xft xinerama xml xorg xscreensaver xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="ja en" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18 ruby19 jruby ree18" USERLAND="GNU" VIDEO_CARDS="vesa radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Hans de Graaff 2011-10-10 19:28:09 UTC]

So you are proposing to change the dependency to:

  ruby_targets_ruby19? ( dev-lang/ruby:1.9 )

right? If that is the case then I suppose we could do away with this virtual altogether since we are basically just repeating the dependency on the ruby target.

@Diego: any thoughts on this since you added this initially?

[Comment 2 Shunsuke Shimizu 2011-10-11 00:14:10 UTC]

(In reply to comment #1)
> So you are proposing to change the dependency to:
> 
>   ruby_targets_ruby19? ( dev-lang/ruby:1.9 )
> 
> right? If that is the case then I suppose we could do away with this virtual
> altogether since we are basically just repeating the dependency on the ruby
> target.

Right.

I also think we could do away with the virtual, as you said.

[Comment 3 Hans de Graaff 2011-10-12 18:13:21 UTC]

I have added a -r4 version that depends directly on ruby:1.9. We can slowly remove virtual/ruby-test-unit from the ebuilds and then remove the virtual itself. I'll leave this bug open until we are ready for that.

Thanks for the suggesting and for testing.

[Comment 4 Hans de Graaff 2014-07-18 07:33:14 UTC]

# Hans de Graaff <[e-mail]> (18 Jul 2014)
# Mask for removal in 30 days for bug 380711.
# This virtual always was a no-op and can be removed from
# ebuilds without consequences.
virtual/ruby-test-unit