Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 380521 - gnome.org.eclass needs to manually add xz-utils to DEPEND when ${GNOME_TARBALL_SUFFIX} == xz
Summary: gnome.org.eclass needs to manually add xz-utils to DEPEND when ${GNOME_TARBAL...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 17:02 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2011-09-12 15:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
patch for gnome.org.eclass (gnome.org.eclass.patch,469 bytes, patch)
2011-08-24 17:02 UTC, Alexandre Rostovtsev (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-08-24 17:02:12 UTC 
Created attachment 284497 [details, diff]
patch for gnome.org.eclass

According to vapier[1] and flameeyes[2], even though xz-utils is part of the system set, packages must still explicitly add it to their DEPEND if they use it at build time. However, doing so manually in every gnome-related package that uses xz tarballs would be crazy. Therefore, I believe that gnome.org.eclass should automatically add app-arch/xz-utils to DEPEND when ${GNOME_TARBALL_SUFFIX} == xz.

Patch is attached.

[1] http://archives.gentoo.org/gentoo-dev/msg_a0d4833eb314d1be5d5802a3b710e0a4.xml
[2] http://archives.gentoo.org/gentoo-dev/msg_3acfceb893484e04cb8d4ec2cd79d39e.xml
Comment 1 Pacho Ramos gentoo-dev 2011-08-27 22:28:42 UTC 
Patch looks ok to me, will try it and commit if works ok for me (and nobody finds any issue with it)
Comment 2 Pacho Ramos gentoo-dev 2011-09-12 15:55:09 UTC 
Done, thanks again Alexandre