380285 – app-misc/editor-wrapper-3 doesn't work with dash

Bug 380285 - app-misc/editor-wrapper-3 doesn't work with dash

Summary: app-misc/editor-wrapper-3 doesn't work with dash

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-08-22 21:07 UTC by Štěpán Dalecký
Modified:	2011-08-22 22:34 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
editor.patch (editor.patch,300 bytes, patch) 2011-08-22 21:45 UTC, Lars Wendler (Polynomial-C) (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Štěpán Dalecký 2011-08-22 21:07:12 UTC

Reproduce:

1)Make dash your default shell(/bin/sh)
2)set EDITOR variable to nothing(EDITOR="")
3)run /usr/libexec/editor
4)it says something like: "EDITOR variable must be set"

Try same thing with bash and it is ok.

Problem appears for example in visudo.

Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2011-08-22 21:45:35 UTC

Created attachment 284259 [details, diff]
editor.patch

Possible fix...

Comment 2 Ulrich Müller gentoo-dev

2011-08-22 22:18:18 UTC

(In reply to comment #1)
> Created attachment 284259 [details, diff]
> editor.patch
> 
> Possible fix...

Indeed, &> isn't POSIX shell syntax.
Štěpán, can you confirm that the patch fixes the problem?

Comment 3 Štěpán Dalecký 2011-08-22 22:29:28 UTC

Yes, I tested it and it looks ok. So I think that patch fix the problem.

Someone else could approve it?

Comment 4 Ulrich Müller gentoo-dev

2011-08-22 22:34:48 UTC

Fixed in editor-wrapper-4.
Thank you for reporting the problem and for testing.