Bug 380085 – dev-util/elfkickers-3.0-r1 keyword request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anthony Basile 2011-08-21 15:00:58 UTC]

After 10 years of silence upstream a new version of elfkickers was released about 2 months ago.  I dropped the older keywording because it was a total rewrite and anything mangling elfs is potentially dangerous.

The old version was keyworded for

   amd64 arm hppa mips ppc ppc64 sparc x86 x86-fbsd

I dropped the new on to just amd64 and x86.  It would be nice to have the older keywords back.  With recent renewed interest in mips, I'll add them too.

Reproducible: Always

[Comment 1 Kacper Kowalik (Xarthisius) (RETIRED) 2011-08-21 16:11:12 UTC]

ppc/ppc64 keywords dropped

[Comment 2 Raúl Porcel (RETIRED) 2011-09-03 15:36:39 UTC]

alpha/ia64/s390/sh didn't had keywords here

[Comment 3 Naohiro Aota 2011-09-04 12:18:15 UTC]

Created attachment 285521 [details, diff]
patch to build on FreeBSD

We need this patch to build on x86-fbsd. The patch is originate from FreeBSD ports, so it might be working.
Please check and add (or allow me to add) this patch, then I'll keyword it.

[Comment 4 Markus Meier 2011-09-05 20:36:40 UTC]

~arm done

[Comment 5 Anthony Basile 2011-09-05 20:41:29 UTC]

(In reply to comment #3)
> Created attachment 285521 [details, diff]
> patch to build on FreeBSD
> 
> We need this patch to build on x86-fbsd. The patch is originate from FreeBSD
> ports, so it might be working.
> Please check and add (or allow me to add) this patch, then I'll keyword it.

I'll add the patch.  I'm a bit concerned though because FreeBSD does define some of those values, eg PT_GNU_STACK 0x6474e551 is defined in sys/elf.h.  However, not being familiar with fbsd/gentoo, I can't say whether it would be a good idea to #include <sys/elf.h> etc.

[Comment 6 Naohiro Aota 2011-09-06 03:26:06 UTC]

(In reply to comment #5)
> (In reply to comment #3)
> > Created attachment 285521 [details, diff]
> > patch to build on FreeBSD
> > 
> > We need this patch to build on x86-fbsd. The patch is originate from FreeBSD
> > ports, so it might be working.
> > Please check and add (or allow me to add) this patch, then I'll keyword it.
> 
> I'll add the patch.  I'm a bit concerned though because FreeBSD does define
> some of those values, eg PT_GNU_STACK 0x6474e551 is defined in sys/elf.h. 
> However, not being familiar with fbsd/gentoo, I can't say whether it would be a
> good idea to #include <sys/elf.h> etc.

Yes, it's in sys/elf_common.h on FreeBSD 8.2, but not older ones. BSD team does not dropped 8.0 or 7.2, so we might need the patch. (yes both 8.0 and 7.2 are obsolete ... but even 7.4 doesn't have the definition)

[Comment 7 Anthony Basile 2011-09-06 13:22:26 UTC]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > Created attachment 285521 [details, diff]
> > > patch to build on FreeBSD
> > > 
> > > We need this patch to build on x86-fbsd. The patch is originate from FreeBSD
> > > ports, so it might be working.
> > > Please check and add (or allow me to add) this patch, then I'll keyword it.
> > 
> > I'll add the patch.  I'm a bit concerned though because FreeBSD does define
> > some of those values, eg PT_GNU_STACK 0x6474e551 is defined in sys/elf.h. 
> > However, not being familiar with fbsd/gentoo, I can't say whether it would be a
> > good idea to #include <sys/elf.h> etc.
> 
> Yes, it's in sys/elf_common.h on FreeBSD 8.2, but not older ones. BSD team does
> not dropped 8.0 or 7.2, so we might need the patch. (yes both 8.0 and 7.2 are
> obsolete ... but even 7.4 doesn't have the definition)

Makes sense.  I only have vanilla (ie non-Gentoo) FreeBSD 8.2.

Anyhow, the patch is in elfkickers-3.0-r2.  Please consider keywording it.  Thanks :)

[Comment 8 Matt Turner 2011-09-06 18:07:00 UTC]

Added ~mips.

[Comment 9 Naohiro Aota 2011-09-08 14:44:32 UTC]

~x86-fbsd added

[Comment 10 Jeroen Roovers (RETIRED) 2011-09-16 16:50:01 UTC]

Marked ~hppa.

[Comment 11 Raúl Porcel (RETIRED) 2011-09-24 17:24:12 UTC]

~sparc done, closing