Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 38001 - Patch to provide faad2's xmms plugin
Summary: Patch to provide faad2's xmms plugin
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-12 13:13 UTC by Douglas Pollock
Modified: 2004-02-02 00:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to faad2's ebuild (faad2-xmms.patch,1.65 KB, patch)
2004-01-12 13:14 UTC, Douglas Pollock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Pollock 2004-01-12 13:13:38 UTC
Not elegant, but it works.  Feel free to modify it into whatever style you like.

Tested and works loading my iTunes m4a files from a Windows XP partition into XMMS.
Comment 1 Douglas Pollock 2004-01-12 13:14:08 UTC
Created attachment 23696 [details, diff]
Patch to faad2's ebuild
Comment 2 Jeremy Huddleston (RETIRED) gentoo-dev 2004-01-31 20:44:56 UTC
I'll take a look at this.
Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev 2004-01-31 21:16:44 UTC
works great.  thanks.  in portage with version bump
Comment 4 Douglas Pollock 2004-02-01 07:23:20 UTC
Many apologies.  I found this out at the beginning of the week, and should have mentioned it here immediately.  There's a problem with the dynamic linker during the install phase if you do not already fadd2 installed.  It incorrectly resolves a linked library to the non-image version of the faad2 library.  This means that those with faad2 already installed can upgrade, but clean installs fail.

I don't have time to look at this for a week or so; I'm at EclipseCon with work.

If you want, it should just be one more tweak to the makefile.  Otherwise, I'll find it when I get back.

In the meantime, I'd recommend rolling back this change.  Reduced functionality is probably better than broken ebuilds.

Sorry once again....
Comment 5 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-01 12:09:34 UTC
ImageMagick was having this same problem a few months back... I'll check out how they fixed it and try to implement the same fix.  It's probably just throwing in the correct order of -L to the LDFLAGS.
Comment 6 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-02 00:22:02 UTC
Alright... I ended up not using this patch... instead, changing emake to make causes compilation to succeed, but we still have the -lfaad errors on installation if it's not an upgrade... so I just 'doexe' them before running the make install... it's not pretty, but it works...  A patch to the Makefile.am would be best, but I'm not an automake/autoconf guru.