Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 379263 - [QA] net-irc/xchat: Fix implicit declarations
Summary: [QA] net-irc/xchat: Fix implicit declarations
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL: http://sourceforge.net/tracker/index....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-15 13:27 UTC by Dustin Polke
Modified: 2014-08-01 04:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-Bug-2355255-Fix-some-implicit-declarations.patch (0001-Bug-2355255-Fix-some-implicit-declarations.patch,3.79 KB, patch)
2011-08-15 13:29 UTC, Dustin Polke
Details | Diff
0002-Fix-implicit-declaration-of-setup_apply_real-change-.patch (0002-Fix-implicit-declaration-of-setup_apply_real-change-.patch,1.17 KB, patch)
2011-08-15 13:30 UTC, Dustin Polke
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dustin Polke 2011-08-15 13:27:40 UTC
* QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * outbound.c:580: warning: implicit declaration of function chanopt_command
 * chanlist.c:639: warning: implicit declaration of function menu_addfavoritemenu
 * fe-gtk.c:784: warning: implicit declaration of function setup_apply_real
 * menu.c:1026: warning: implicit declaration of function servlist_autojoinedit
 * notifygui.c:268: warning: implicit declaration of function open_query
 * maingui.c:1592: warning: implicit declaration of function log_open_or_close
 * plugin-tray.c:548: warning: implicit declaration of function handle_command
 * servlistgui.c:971: warning: implicit declaration of function rfc_casecmp
 * setup.c:1962: warning: implicit declaration of function tray_apply_setup
 * userlistgui.c:128: warning: implicit declaration of function fe_set_title

I'll attach two patches to fix these.
First patch is trivial, adding missing header includes.
Second patch requires to fix changed API of internal function which I don't know if I have guessed correctly what the new argument should be (TRUE or FALSE).

I've added upstream bug URL and try to submit patches there as well.
Comment 1 Dustin Polke 2011-08-15 13:29:11 UTC
Created attachment 283419 [details, diff]
0001-Bug-2355255-Fix-some-implicit-declarations.patch
Comment 2 Dustin Polke 2011-08-15 13:30:07 UTC
Created attachment 283421 [details, diff]
0002-Fix-implicit-declaration-of-setup_apply_real-change-.patch
Comment 3 David J Cozatt 2014-07-31 17:31:27 UTC
xchat has had no new releases since august 2010. There were a string of bugs that i had gleaned some patches for from the bug tracker and posted. it should probably be removed from portage and hexchat preferred.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2014-08-01 04:49:14 UTC
Already done. See bug #460038