Bug 378283 – sys-libs/gpm : add USE=static-libs support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2011-08-08 11:02:38 UTC]

This package installs also static libs ".a" please provide do add relative
USE. TIA

/usr/lib/libgpm.a
/usr/lib/libgpm.so

[Comment 1 Jeroen Roovers (RETIRED) 2012-07-18 16:17:54 UTC]

*** Bug 426894 has been marked as a duplicate of this bug. ***

[Comment 2 Sean McGovern 2012-07-18 16:42:53 UTC]

Oh...fantastic! Sorry about the duplication, I missed this one when I did a search.

I wouldn't mind taking a crack at implementing this -- is that OK?

Also, can/should I update it to EAPI 4?

[Comment 3 SpanKY 2012-08-18 04:41:55 UTC]

(In reply to comment #2)

feel free

[Comment 4 Sean McGovern 2012-08-24 05:18:47 UTC]

Created attachment 322060 [details]
ebuild for gpm 1.20.6 with shared library as default

Attached is my first attempt at an updated ebuild.

Comments and suggestions welcome.

[Comment 5 SpanKY 2012-08-24 15:55:32 UTC]

Comment on attachment 322060 [details]
ebuild for gpm 1.20.6 with shared library as default

(In reply to comment #4)

we usually want to see diffs, not entire files, as it is very easy to review the former but much harder to review the latter.  could you post it in the unidiff format please (`diff -u`) ?

[Comment 6 Sean McGovern 2012-08-24 18:01:50 UTC]

Created attachment 322120 [details, diff]
diff of sys-libs/gpm with shared libs as default

[Comment 7 SpanKY 2012-08-24 22:14:41 UTC]

Comment on attachment 322120 [details, diff]
diff of sys-libs/gpm with shared libs as default

yes, this is one way of doing it.  but generally we try to avoid over-compiling.

instead of that src_install change, you added this to src_prepare:

if ! use static-libs ; then
   sed -i \
       -e '/^all:/s:lib/libgpm.a::' \
       -e '/INSTALL_DATA.*libgpm.a/d' \
       src/Makefile.in || die
fi

super bonus points if you patched the source to respect --enable-static flags :)

[Comment 8 Sean McGovern 2012-08-27 07:02:20 UTC]

Created attachment 322342 [details, diff]
sys-libs/gpm ebuild patch for static-libs USE support

[Comment 9 Sean McGovern 2012-08-27 07:03:06 UTC]

Created attachment 322344 [details, diff]
configure patch to not build static libgpm by default

[Comment 10 Sean McGovern 2012-09-03 22:21:37 UTC]

Now that Bugzilla is back, *ping*!

[Comment 11 Sean McGovern 2012-09-17 13:29:01 UTC]

*ping^2*

[Comment 12 Sean McGovern 2012-10-26 13:05:56 UTC]

*ping^3*

[Comment 13 Diego Elio Pettenò (RETIRED) 2012-10-26 15:28:14 UTC]

I have it open, I have it downloaded, just haven't had the time, coffee and then I'll apply it ;)

[Comment 14 Agostino Sarubbo 2012-10-26 17:14:13 UTC]

For the record, this issue has been reported upstream.

[Comment 15 Sean McGovern 2012-10-26 17:20:29 UTC]

That's great -- it seems to only be a concern for this specific and any prior releases as their Git repository has long since been introduced to libtool. No release was ever made for this change, however.

[Comment 16 Diego Elio Pettenò (RETIRED) 2012-10-26 20:26:24 UTC]

I have everything in place, _but_ I'm checking now the reverse deps as splashutils will be broken by this change, for instance.

[Comment 17 Diego Elio Pettenò (RETIRED) 2012-10-26 20:52:51 UTC]

Okay this one is in.