Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 378123 - kde-base/kdelibs FindMusicBrainz.cmake is broken
Summary: kde-base/kdelibs FindMusicBrainz.cmake is broken
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard: tracking upstream
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-07 19:19 UTC by Nikoli
Modified: 2012-01-21 23:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikoli 2011-08-07 19:19:40 UTC
Please update dep to media-libs/musicbrainz:3 if possible, media-libs/musicbrainz:1 dep seems obsolete and useless:
1) Removing media-libs/musicbrainz:1 and running revdep-rebuild does not detect any breakage.
2) app-cdr/k3b/ChangeLog:
  01 Jan 2008; Alexis Ballier <aballier@gentoo.org> k3b-0.12.17.ebuild,
  k3b-1.0.ebuild, k3b-1.0.1.ebuild, k3b-1.0.1-r1.ebuild, k3b-1.0.2.ebuild,
  k3b-1.0.3.ebuild, k3b-1.0.4.ebuild:
  stick musicbrainz deps to -2*, bug #203784

But now media-libs/musicbrainz-3.0.2:3 is marked stable, no reason for using -2*.
Comment 1 Maciej Mrozowski gentoo-dev 2011-08-08 17:36:19 UTC
The problem is different...

1. musicbrainz:1 cannot be replaced with musicbrainz:3 as the latter is source incompatible with the former

2. musicbrainz handling in k3b is currently broken because FindMusicBrainz.cmake from kdelibs is broken because it doesn't set MUSICBRAINZ_FOUND variable at all - so NO musicbrainz support was ever compiled on k3b after rewrite to KDE4 API (and thus after rewrite of buildsystem to cmake).
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2012-01-10 06:14:51 UTC
does it amount to this?

 if(MUSICBRAINZ_INCLUDE_DIR AND MUSICBRAINZ_LIBRARIES)
    set(MUSICBRAINZ_FIND_QUIETLY TRUE)
+   set(MUSICBRAINZ_FOUND TRUE)

for FindMusicBrainz.cmake ??
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2012-01-21 23:23:45 UTC
(In reply to comment #1)
> The problem is different...
> 
> 1. musicbrainz:1 cannot be replaced with musicbrainz:3 as the latter is source
> incompatible with the former

Correct.

> 
> 2. musicbrainz handling in k3b is currently broken because
> FindMusicBrainz.cmake from kdelibs is broken because it doesn't set
> MUSICBRAINZ_FOUND variable at all - so NO musicbrainz support was ever compiled
> on k3b after rewrite to KDE4 API (and thus after rewrite of buildsystem to
> cmake).

No, not correct. find_package_handle_standard_args is called and sets MUSICBRAINZ_FOUND if the requirements are met.

(In reply to comment #2)
> does it amount to this?
> 
>  if(MUSICBRAINZ_INCLUDE_DIR AND MUSICBRAINZ_LIBRARIES)
>     set(MUSICBRAINZ_FIND_QUIETLY TRUE)
> +   set(MUSICBRAINZ_FOUND TRUE)
> 
> for FindMusicBrainz.cmake ??

Unfortunately not... that's just handling the case where it has already been detected before.


On the whole we can't do much about this. The packages still require the API from versions 1-2.