Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 378075 - mail-filter/dspam-3.10.0-r1 USE=small-scale has no effect
Summary: mail-filter/dspam-3.10.0-r1 USE=small-scale has no effect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alin Năstac (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-07 13:05 UTC by Tom Hendrikx
Modified: 2011-08-08 05:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix small-scale USE flag (dspam-3.10.0-r1.patch,1.68 KB, patch)
2011-08-07 13:05 UTC, Tom Hendrikx
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hendrikx 2011-08-07 13:05:43 UTC
Created attachment 282411 [details, diff]
fix small-scale USE flag

The dspam-3.10.0-r1 ebuild as available in portage has a small-scale USE flag, but it does not work.

This is because of the 'default to domain scale' kludge in the top of src_configure(). When selecting the small-scale USE flag, the configure line ends up like: "--disable-domain-scale [...] --disable-large-scale --enable-domain-scale", effectively selecting domain scale.

The original ebuild as suggested in bug #299090 has a working implementation of this: since small-scale is a no-op use flag, it only makes sure none of the other scale USE flags are enabled in REQUIRED_USE. The end result ('--disable-domain-scale --disable-large-scale') selects small-scale.

If you want to provide domain-scale as the default for backwards compatibility, then set +domain-scale in SCALES_IUSE.

Attached is a patch against the portage ebuild that re-enables this.

As added bonus, the patch removes the /var/run/dspam directory creation, which is handled by 'make install' itself (depending on --daemon passed to configure).
Comment 1 Eray Aslan gentoo-dev 2011-08-07 14:50:55 UTC
Sigh, right.  Thanks for the report.

+  07 Aug 2011; Eray Aslan <eras@gentoo.org> dspam-3.10.0-r1.ebuild:
+  Fix small-scale use flag - bug #378075
+

As a side note, dodir'ing /var/run/dspam in the ebuild is pointless because /var/run can and usually is mounted tmpfs.  Init script should make sure it exists.
Comment 2 Eray Aslan gentoo-dev 2011-08-08 05:25:53 UTC
Bah, forgot to close.