Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 376705 - =net-misc/dahdi-2.4.1-r1 does not respect CFLAGS
Summary: =net-misc/dahdi-2.4.1-r1 does not respect CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 10:13 UTC by Agostino Sarubbo
Modified: 2011-09-02 10:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2011-07-28 10:13:12 UTC 
As per $summary, form build.log:

 gcc -Wp,-MD,/tmp/portage/net-misc/dahdi-2.4.1-r1/work/dahdi-linux-2.4.1/drivers/dahdi/.dahdi_echocan_sec.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/include -I/usr/src/linux-2.6.39-gentoo-r3/arch/x86/include -Iinclude  -include include/generated/autoconf.h -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -Os -m64 -march=core2 -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 -DCONFIG_AS_FXSAVEQ=1 -pipe -Wno-sign-compare -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DHAVE_HRTIMER_ACCESSORS=1  -DMODULE  -I/tmp/portage/net-misc/dahdi-2.4.1-r1/work/dahdi-linux-2.4.1/include -I/tmp/portage/net-misc/dahdi-2.4.1-r1/work/dahdi-linux-2.4.1/drivers/dahdi -DHAVE_WAIT_FOR_COMPLETION_TIMEOUT=1 -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(dahdi_echocan_sec)"  -D"KBUILD_MODNAME=KBUILD_STR(dahdi_echocan_sec)" -c -o /tmp/portage/net-misc/dahdi-2.4.1-r1/work/dahdi-linux-2.4.1/drivers/dahdi/dahdi_echocan_sec.o /tmp/portage/net-misc/dahdi-2.4.1-r1/work/dahdi-linux-2.4.1/drivers/dahdi/dahdi_echocan_sec.c

I think that -Os and other minor flags should be dropped like mno-*

Anyway I don't know why it compiles with core2 if I have native:

CFLAGS="-march=native -O2 -g0"
Comment 1 Agostino Sarubbo gentoo-dev 2011-08-26 13:05:49 UTC 
PLease fix also directly calling of gcc and ld
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2011-09-02 10:56:16 UTC 
This package uses kmod, and as such I have no makefiles to patch to install CFLAGS respect. However, I have fixed the direct calls of CC & LD for you. Hope that will do for now.

+*dahdi-2.5.0-r1 (02 Sep 2011)
+
+  02 Sep 2011; Tony Vroon <chainsaw@gentoo.org> +dahdi-2.5.0-r1.ebuild:
+  Add support for junghanns.net BRI adapters, ebuild work by Felix Tiede closes
+  bug #354321. Stop calling CC/LD directly, closes bug #376705 by Agostino
+  "ago" Sarubbo. Drop unnecessary patch from set, as per Erik Wallin in bug
+  #381335.