Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 376531 - app-emulation/virtualbox-4.0.12: Make PAM optional [enhanced patch]
Summary: app-emulation/virtualbox-4.0.12: Make PAM optional [enhanced patch]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords: InOverlay
Depends on:
Blocks:
 
Reported: 2011-07-26 21:22 UTC by René 'Necoro' Neumann
Modified: 2011-10-24 21:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
virtualbox-4.0.12.ebuild.diff (virtualbox-4.0.12.ebuild.diff,1.40 KB, patch)
2011-07-26 21:22 UTC, René 'Necoro' Neumann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René 'Necoro' Neumann 2011-07-26 21:22:37 UTC
Created attachment 281083 [details, diff]
virtualbox-4.0.12.ebuild.diff

I dislike having PAM as a hard requirement in VirtualBox, especially as it is needed for something I don't really have a need for (the RDP stuff).

Hence I took the patch from bug #351404 and enhanced it: Currently the VBoxAuth module is the only one using PAM, and VRDP is the only thing needing VBoxAuth (<-- this needs to be verified). Therefore I excluded VBoxAuth from building.

This approach probably needs testing, and the warning message might be put to a more prominent place.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-07-26 21:29:27 UTC
I don't have a Gentoo system without pam at hand so I have to rely on you or anybody else with a pam-less system to give me reliable testing results before I add this patch to portage.
However I can add this patch to poly-c overlay so you guys don't have to patch the ebuild(s) yourself.
Comment 2 René 'Necoro' Neumann 2011-07-26 22:03:27 UTC
I am definitly not in the position to be a trusted tester: I use VBox only very seldomly and then only the most basic features. So my judgement of whether it works or not is not something one should rely on :).

Regarding the overlay: I can only speak for myself, but as your overlay contains quite some patched stable packages (for instance pidgin or subversion), I'm a bit reluctant of adding this. I think for the moment, I'll stick with keeping the patch in my private repository.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-08-07 11:01:38 UTC
This is now in the poly-c overlay. Please give it a thorough testing and report back here whether it works or not.
I won't commit these changes into portage before I got positive reports in this bug.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-10-24 21:59:45 UTC
+  24 Oct 2011; Lars Wendler <polynomial-c@gentoo.org> virtualbox-4.0.12.ebuild,
+  virtualbox-4.1.2.ebuild, virtualbox-4.1.4.ebuild:
+  Forced python-2 on installation (bug #350237). Made the package's decription
+  the same as virtualbox-bin (bug #366305). Made pam support optional with
+  changes provided by René 'Necoro' Neumann (bug #376531). Added
+  vboxwebsrv<->java dependency to REQUIRED_USE (bug #382061).
+