Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 376337 - =sci-libs/ccp4-libs-6.1.3-r10 does not respect CFLAGS
Summary: =sci-libs/ccp4-libs-6.1.3-r10 does not respect CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Justin Lecher (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 11:13 UTC by Agostino Sarubbo
Modified: 2011-07-25 19:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2011-07-25 11:13:52 UTC 
/bin/sh ../libtool --tag=CXX   --mode=compile x86_64-pc-linux-gnu-g++ -DPACKAGE_NAME=\"DiffractionImage\" -DPACKAGE_TARNAME=\"diffractionimage\" -DPACKAGE_VERSION=\"6.1.1\" -DPACKAGE_STRING=\"DiffractionImage\ 6.1.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"diffractionimage\" -DVERSION=\"6.1.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DSTDC_HEADERS=1 -DHAVE_LIBM=1 -I.   -I/usr/include/python2.7 -I/etc/java-config-2/current-system-vm/include -I/etc/java-config-2/current-system-vm/include/linux  -march=native -O2   -fPIC -g -O0 -MT FrmRoutines.lo -MD -MP -MF .deps/FrmRoutines.Tpo -c -o FrmRoutines.lo FrmRoutines.cpp


Please drop -g and -O0
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2011-07-25 19:10:42 UTC 
I can try to drop the -g. All optimization drops have to be taken seriously. I had bad experience removing those -O* changes which led to scientifically wrong results.
Comment 2 Agostino Sarubbo gentoo-dev 2011-07-25 19:17:48 UTC 
(In reply to comment #1)
> I can try to drop the -g. All optimization drops have to be taken seriously. I
> had bad experience removing those -O* changes which led to scientifically wrong
> results.

If you want, you can add USE="custom-cflags" if the user wants custom-cflags, - O0 should be dropped by the use . So, adding also a warning is a good idea.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2011-07-25 19:44:02 UTC 
change commited. -g is dropped everywhere.
Comment 4 Justin Lecher (RETIRED) gentoo-dev 2011-07-25 19:48:38 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > I can try to drop the -g. All optimization drops have to be taken seriously. I
> > had bad experience removing those -O* changes which led to scientifically wrong
> > results.
> 
> If you want, you can add USE="custom-cflags" if the user wants custom-cflags, -
> O0 should be dropped by the use . So, adding also a warning is a good idea.

It is not about warnings. People use this programs to create scientific results. Changing the optimization can lead to unforeseen results if not wrong results. Therefore I will stick to any reduction in optimization as upstream wants it.