Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 376075 - x11-themes/gnome-themes automake called by maintainer-mode
Summary: x11-themes/gnome-themes automake called by maintainer-mode
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Highest QA (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://blog.flameeyes.eu/2008/06/13/m...
Whiteboard:
Keywords:
Depends on:
Blocks: bad-autotools
  Show dependency tree
 
Reported: 2011-07-23 10:37 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2011-08-27 19:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (gnome-themes-2.32.1-r1:20110722-040711.log,228.85 KB, text/plain)
2011-07-23 10:37 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2011-07-23 10:37:12 UTC
Created attachment 280715 [details]
Build log

Hello,

You're receiving this canned (template-based) bug report because I found a problem with a package during my tinderbox run.

The package in question is running automake (and most likely other autotools) during compile phase by maintainer-mode. You can see in my blog post in the URL field why that's a problem, and how to address the issue, but in general, you don't want maintainer-mode rebuild during compile phase, especially since it can cause multiple run of econf.

The causes of maintainer-mode rebuild are various, but most likely it's because of a patch that changes Makefile.am or configure.ac/in and don't rebuild autotools properly. The way to fix this is almost always to inherit autotools eclass and run eautomake/eautoreconf (as needed; eautoconf should only be used when automake is not involved, which is not the case here) during src_unpack phase.

Thanks,
Diego
Comment 1 Pacho Ramos gentoo-dev 2011-07-23 11:13:42 UTC
I cannot reproduce this
Comment 2 Pacho Ramos gentoo-dev 2011-08-05 12:00:19 UTC
Maybe this could be caused by this:
        # Remove themes now provided by x11-themes/gnome-themes-standard
        sed 's:HighContrast.*\\:\\:g' -i $(find . -name Makefile.am -o -name Makefile.in) || die
        sed 's:LowContrast.*\\:\\:g' -i $(find . -name Makefile.am -o -name Makefile.in) || die

And running separate sed commands for .am files and, later, for .in files could help. Please try it (as it still doesn't fail for me)