Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 375899 - www-client/firefox-5.0-r2 www-client/icecat-5.0-r1 www-client/seamonkey-2.2-r1 fail to build with >=net-misc/curl-7.21.7
Summary: www-client/firefox-5.0-r2 www-client/icecat-5.0-r1 www-client/seamonkey-2.2-r...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 376027 376349 376415 (view as bug list)
Depends on:
Blocks: curl-7.21.7
  Show dependency tree
 
Reported: 2011-07-21 18:59 UTC by Bartosz Brachaczek
Modified: 2011-07-26 17:06 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,199.49 KB, application/x-xz)
2011-07-21 18:59 UTC, Bartosz Brachaczek
Details
firefox-5.0-r2.ebuild.patch (firefox-5.0-r2.ebuild.patch,655 bytes, patch)
2011-07-22 18:50 UTC, Sander Sweers
Details | Diff
Curl Patch for www-client/seamonkey-2.2-r1 (curl_types.patch,1.97 KB, text/plain)
2011-07-26 02:31 UTC, Billy DeVincentis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bartosz Brachaczek 2011-07-21 18:59:22 UTC
Created attachment 280543 [details]
build.log.xz

It's because crashreporter tries to include <curl/types.h> which curl stopped providing in version 7.21.7. In curl 7.21.7 that header is basically empty anyway.

Please note that current firefox ebuild doesn't specify any dependency on curl at all, see bug 374963.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-07-21 19:22:47 UTC
Same problem with seamonkey and icecat.
Comment 2 Bartosz Brachaczek 2011-07-21 19:38:23 UTC
>In curl 7.21.7 that header is basically empty anyway.

I meant: In curl 7.21.6 that header is basically empty anyway.
Comment 3 Derek Dolney 2011-07-21 20:45:16 UTC
xulrunner-2.0.1-r1 also fails to build with newer curl.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-07-22 09:39:02 UTC
*** Bug 375967 has been marked as a duplicate of this bug. ***
Comment 5 Steffen Hau 2011-07-22 10:38:30 UTC
This also effects mail-client/thunderbird-5.0
Comment 6 Sander Sweers 2011-07-22 18:47:59 UTC
*** Bug 376027 has been marked as a duplicate of this bug. ***
Comment 7 Sander Sweers 2011-07-22 18:50:42 UTC
Created attachment 280667 [details, diff]
firefox-5.0-r2.ebuild.patch

This ebuild patch removes the necessary includes from firefox-5.0. The same fix should be applied to the earlier versions and packages in this bug.
Comment 8 Cyprien Nicolas (fulax) 2011-07-22 19:34:08 UTC
Upstream already have an approved patch, for mozilla-central at least:
http://hg.mozilla.org/mozilla-central/rev/aa5bfc851c35

Upstream firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=673072
Comment 9 Billy DeVincentis 2011-07-23 12:34:22 UTC
This seems to affect ALL Mozilla products. In reemerging my system, firefox, thunderbird, seamonkey, and xulrunner all failed. Hope the upstream patches get put into portage soon.
Comment 10 Guy 2011-07-24 19:02:49 UTC
Rather than wait for the individual patches a bunch of ebuilds (like all the Mozilla based group, raptor and potentially others) it might be best to simply mask the latest version of curl.

Since the header file involved is basically empty and it's removal upstream appears to be housekeeping related there doesn't and I haven't seen any packages requiring the latest version of curl, masking and giving this issue time to work out might be the best thing for most of us users to do.

First: mask latest curl
   echo ">=net-misc/curl-7.21.7" >> /etc/portage/package.mask

Second: emerge curl to ensure downgrade to last version of curl which includes needed header.
   emerge curl

Last - finish your upgrades (with the understanding you'll need to revisit this issue at a future date).
   emerge -1uND @world (or whatever else you were doing)

Also, the recommendation to do USE="-crashreporter" doesn't bypass the issue.

Note that anything with 'xulrunner' as a dependency will fail. This may be why firefox et al also fail.
Comment 11 Christoph Mende (RETIRED) gentoo-dev 2011-07-25 10:49:56 UTC
Mozilla team, please fix this asap. It's a simple fix (just remove the includes, the header contains one comment, nothing else, since 2004) and curl-7.21.7 is a security bump and should go stable asap.
Comment 12 Billy DeVincentis 2011-07-25 11:47:42 UTC
The upstream patch works perfectly for firefox. The principal is the same for seamonkey but the patch needs to be modified for seamonkey. If anyone cares to step up....
Comment 13 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-07-25 12:29:58 UTC
*** Bug 376349 has been marked as a duplicate of this bug. ***
Comment 14 Billy DeVincentis 2011-07-26 02:31:07 UTC
Created attachment 280973 [details]
Curl Patch for www-client/seamonkey-2.2-r1

Just created this patch for Seamonkey. Compiles and works for me.
Comment 15 Jory A. Pratt gentoo-dev 2011-07-26 03:10:44 UTC
*** Bug 376415 has been marked as a duplicate of this bug. ***
Comment 16 Jory A. Pratt gentoo-dev 2011-07-26 03:12:50 UTC
(In reply to comment #14)
> Created attachment 280973 [details]
> Curl Patch for www-client/seamonkey-2.2-r1
> 
> Just created this patch for Seamonkey. Compiles and works for me.

I appreciate you updating the patch for seamonkey-2.2, however we can simply do the same sed with a slighly modified path for each file which resides in ${S}/mozilla/.
Comment 17 Jory A. Pratt gentoo-dev 2011-07-26 03:26:26 UTC
(In reply to comment #11)
> Mozilla team, please fix this asap. It's a simple fix (just remove the
> includes, the header contains one comment, nothing else, since 2004) and
> curl-7.21.7 is a security bump and should go stable asap.

Firefox-5.0 and Thunderbird-5.0 have been fixed, I will have to double check xulrunner-1.9.2.x before curl-7.21.7 can go stable, but should be just as trivial as Firefox-5.0. Seamonkey-2.2 and Icecat-5.0 will follow suit Seamonkey stable will also be addressed soon as Lars has a chance.
Comment 18 Christoph Mende (RETIRED) gentoo-dev 2011-07-26 07:26:22 UTC
(In reply to comment #17)
> Firefox-5.0 and Thunderbird-5.0 have been fixed, I will have to double check
> xulrunner-1.9.2.x before curl-7.21.7 can go stable, but should be just as
> trivial as Firefox-5.0. Seamonkey-2.2 and Icecat-5.0 will follow suit Seamonkey
> stable will also be addressed soon as Lars has a chance.

Thanks. The fix is always trivial, here's the header from 7.21.4:
~ % cat /usr/include/curl/types.h 
/* not used */
~ % 

So there was no API break ;)
Comment 19 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-07-26 12:29:00 UTC
+  26 Jul 2011; Lars Wendler <polynomial-c@gentoo.org>
+  seamonkey-2.0.14-r1.ebuild,
+  +files/seamonkey-2.0.14-curl7217-includes-fix.patch, seamonkey-2.1.ebuild,
+  seamonkey-2.2-r1.ebuild, +files/seamonkey-2.2-curl7217-includes-fix.patch:
+  Fixed compilation with >=curl-7.21.7 (bug #375899).
+
Comment 20 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-07-26 13:11:08 UTC
+  26 Jul 2011; Lars Wendler <polynomial-c@gentoo.org> icecat-3.6.16-r1.ebuild,
+  icecat-3.6.16-r2.ebuild, +files/icecat-3.6.16-curl7217-includes-fix.patch,
+  icecat-4.0.1-r1.ebuild, icecat-5.0-r1.ebuild,
+  +files/icecat-5.0-curl7217-includes-fix.patch:
+  Fixed compilation with >=curl-7.21.7 (bug #375899).
+
Comment 21 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2011-07-26 17:03:36 UTC
+  26 Jul 2011; Lars Wendler <polynomial-c@gentoo.org>
+  xulrunner-1.9.2.12.ebuild, xulrunner-1.9.2.17.ebuild,
+  xulrunner-1.9.2.18.ebuild, xulrunner-2.0.1-r1.ebuild:
+  Fixed compilation with >=curl-7.21.7 (bug #375899).
+