Created attachment 280493 [details] update backwards compatibility patch iniparser-3.0 final has been released; there were API changes, but they're minor, and were essentially accounted for in a patch we applied to the beta. I've attached an updated version of this patch.
I bumped it a while ago. Do we really need the backwards compatibility patch?
Created attachment 298941 [details] build.log for samba[client,winbind] with iniparser-3.0
IIRC it was required for building samba with +client or +winbind. Samba still fails with Linking shared library bin/pam_winbind.so ../nsswitch/pam_winbind.o: In function `_pam_parse': pam_winbind.c:(.text+0x4c1): undefined reference to `iniparser_getstr' pam_winbind.c:(.text+0x4de): undefined reference to `iniparser_getstr' pam_winbind.c:(.text+0x6e8): undefined reference to `iniparser_getstr' ../nsswitch/pam_winbind.o: In function `get_conf_item_string': pam_winbind.c:(.text+0x13df): undefined reference to `iniparser_getstr' collect2: ld returned 1 exit status It seems like the "correct" thing to do would be to get upstream samba to switch to the new API, though patching iniparser is easier.
I successfully applied the patch with iniparser-3.0.0 (re-emerged with FEATURES="keepwork") but I still cannot build Samba with the pam USE flag.
Created attachment 299065 [details, diff] fix compat patch only working for C++ OK; I guess iniparser.h changed a bit from when I wrote the patch. (Aside: how did this happen? Interesting that a .h file changed w/o the version changing.) Sorry for not testing the patch a second time; samba compiles for me now.
I downgraded from 3.0.0 to 3.0b-r1 and did not apply any patch and Samba compiles fine with that.
That's not surprising: the ebuild applies iniparser-3.0b-fix-set-functions.patch . The patches I've posted are just updates of that patch. Can you confirm that samba compiles properly with iniparser-3.0 (and the fixed patch)?
(In reply to comment #7) > That's not surprising: the ebuild applies > iniparser-3.0b-fix-set-functions.patch . The patches I've posted are just > updates of that patch. > > Can you confirm that samba compiles properly with iniparser-3.0 (and the fixed > patch)? I tried that and I could not get it to work. That is why I downgraded. On top of that, 3.0.0 is marked ~amd64 and the only thing that depends on iniparser on my machine is samba because of the client and winbind USE flags. There is no real good reason for me to use 3.0.0.
OK, well, if the latest patch (dated 2012-01-16 15:30 UTC) doesn't work for you, please post a build log. If you haven't tested the latest patch, please do so if you have time, and report your findings. Other comments to this bug are unlikely to be productive. The motivation to use this package is that the current stable version in portage is listed as a beta, and presumably will not be supported upstream now that the final version has been released.
Patch required for current app-cdr/isomaster (at least).
(In reply to comment #3) > IIRC it was required for building samba with +client or +winbind. > > Samba still fails with It may not be the "Gentoo way" (and neither is the default on 'filters' use flag for net-print/cups) but for Samba one can use the included iniparser instead of the system one - Samba will build and run just fine without dev-libs/iniparser once the ebuild is edited to remove the dependency on dev-libs/iniparser and the hardcoded configure option "--without-included-iniparser" is replaced with "--with-included-iniparser". On my systems Samba was the only package dependent on dev-libs/iniparser so I could totally remove it.
(In reply to comment #11) > (In reply to comment #3) > > IIRC it was required for building samba with +client or +winbind. > > > > Samba still fails with > > It may not be the "Gentoo way" (and neither is the default on 'filters' use > flag for net-print/cups) but for Samba one can use the included iniparser > instead of the system one - Samba will build and run just fine without > dev-libs/iniparser once the ebuild is edited to remove the dependency on > dev-libs/iniparser and the hardcoded configure option > "--without-included-iniparser" is replaced with "--with-included-iniparser". > > On my systems Samba was the only package dependent on dev-libs/iniparser so > I could totally remove it. Yes, this is not the gentoo way! Samba ebuilds got fixed a while ago (see bug #399141). If there is any other package failing with iniparser-3.0 open a separate bug.
