Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 37581 - Portage do MD5SUM twice on emerge --fetch ? (or not ?)
Summary: Portage do MD5SUM twice on emerge --fetch ? (or not ?)
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-08 02:46 UTC by Phattanon Duangdara
Modified: 2004-08-02 04:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Phattanon Duangdara 2004-01-08 02:46:27 UTC
It's looks like portage do MD5SUM twice on package sources
when doing emerge --fetch.

I noted it when fetching some large packages such as kernel on my Gentoo in portage harddisk (USB1) with 64MB of RAM computer box. I wait lone time after message:

>>> emerge (1 of 1) sys-kernel/vanilla-sources-2.4.24 to /

for good MD5SUM ('MD5 ;-)') message come.

>>> Previously fetched file: linux-2.4.24.tar.bz2 MD5 ;-)

When this line show I think it do MD5SUM once and again.
I need to wait a long time. I think we can't notice this if
fetch on computer that have much of RAM because it cached.

>>> md5 src_uri ;-) linux-2.4.24.tar.bz2

It not looks like a serious bug. But it affected performance on less RAM machine.
I think second MD5SUM is only for ebuild unpacking. It's not neccessary for when fetch.

Sorry if portage already do MD5 once. I don't sure about this. Also happened on lastest portage.

Reproducible: Always
Steps to Reproduce:
1.emerge --fetch some large packages on slow harddisk and less RAM
2.notice the MD5SUM messages and MD5SUM time

Actual Results:  
It's looks like portage do MD5SUM twice

- First time after fetched files to check for valid archive.
- Second time for validate integrity of archive before unpack (not neccessary).

Expected Results:  
MD5SUM once.
Comment 1 Phattanon Duangdara 2004-01-08 02:48:00 UTC
Addition: Only happened when fetch old files !!!
Comment 2 Marius Mauch (RETIRED) gentoo-dev 2004-01-08 17:37:53 UTC
The check after fetch was implemented on user request some time ago, so that `emerge -f` already detects errors and a later unattended compile won't get interrupted by md5 errors. I'll look if we can change it so that `emerge foo` will only do one md5 check (but if it requires major changes you'll have to live with it).
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2004-01-08 18:00:27 UTC
Hmm, I should check the code before I talk: It's already so that the md5 check on fetching is only done if you use --fetchonly. Which portage version are you using and what was the exact command you used ?
Comment 4 Phattanon Duangdara 2004-01-12 02:05:55 UTC
It's also check MD5 twice with already fetch file.

I usually use 'emerge -f packages...' or 'emerge -uf packages...' on my portable HDD (usb1) which very slow.

Using portage 2.0.49-r21 (lastest I have).

Hmm. I should try 'emerge package' and 'emerge -f package'
and compare MD5 output (same package).
Comment 5 Marius Mauch (RETIRED) gentoo-dev 2004-06-05 10:48:57 UTC
still an issue ?
Comment 6 Brian Harring (RETIRED) gentoo-dev 2004-08-02 04:15:28 UTC
I haven't seen this in quite some time, closing.
Reopen (again) if it pops up :)