Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 37514 - small patch to equery catching user input
Summary: small patch to equery catching user input
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-07 13:15 UTC by Eldad Zack (RETIRED)
Modified: 2004-01-08 18:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (equery-ez1.patch,608 bytes, patch)
2004-01-07 13:19 UTC, Eldad Zack (RETIRED)
Details | Diff
proposed patch (equery-ez2.patch,1.00 KB, patch)
2004-01-07 13:22 UTC, Eldad Zack (RETIRED)
Details | Diff
proposed patch (equery-ez3.patch,1.48 KB, patch)
2004-01-07 14:53 UTC, Eldad Zack (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eldad Zack (RETIRED) gentoo-dev 2004-01-07 13:15:35 UTC
equery doesn't say anything if you feed it with a command that he doesn't recognize. also, if you arguments given, it simply exits silently.
I think that in both of these cases it should printUsage().

As a sidenote - Karl, great job on equery.
Comment 1 Eldad Zack (RETIRED) gentoo-dev 2004-01-07 13:19:40 UTC
Created attachment 23341 [details, diff]
proposed patch

This patch also moves sys.exit(0) inside printUsage(), as it is called three
times now, and the sys.exit(0) statement is redundant.
Comment 2 Eldad Zack (RETIRED) gentoo-dev 2004-01-07 13:22:31 UTC
Created attachment 23342 [details, diff]
proposed patch

the former patch had the redundant sys.exit(0), this one is the real one.
Comment 3 Eldad Zack (RETIRED) gentoo-dev 2004-01-07 14:53:10 UTC
Created attachment 23348 [details, diff]
proposed patch

additional fix - includes color fix from bug 37525 and a logic issue with
--help and -C/--nocolor
Comment 4 Marius Mauch (RETIRED) gentoo-dev 2004-01-08 18:22:04 UTC
fixed in 0.2.0_pre2