374697 – webapp.eclass based pkgs broken binpkgs support

Bug 374697 - webapp.eclass based pkgs broken binpkgs support

Summary: webapp.eclass based pkgs broken binpkgs support

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Web Application Packages Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-07-10 12:52 UTC by Fabio Erculiani (RETIRED)
Modified:	2011-07-12 07:48 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
webapp.eclass patch (webapp-eclass-binpkgs-support-fixes.patch,1.05 KB, patch) 2011-07-10 12:52 UTC, Fabio Erculiani (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Fabio Erculiani (RETIRED) gentoo-dev

2011-07-10 12:52:37 UTC

IS_UPGRADE and IS_REPLACE are not properly reset at runtime, causing failures with binpkgs.
Moreover, the way webapp-config is called in webapp_pkg_prerm() looks wrong, either webapp-config syntax changed or it was broken since day 0.

Please review the eclass patch attached.

Reproducible: Always

Comment 1 Fabio Erculiani (RETIRED) gentoo-dev

2011-07-10 12:52:57 UTC

Created attachment 279603 [details, diff]
webapp.eclass patch

Comment 2 Fabio Erculiani (RETIRED) gentoo-dev

2011-07-10 19:54:07 UTC

Please also see: http://bugs.sabayon.org/show_bug.cgi?id=2536
Should be trivial, too.

Comment 3 Tim Harder gentoo-dev

2011-07-12 07:43:46 UTC

The eclass patch looks fine to me. Feel free to apply it. :)

Comment 4 Fabio Erculiani (RETIRED) gentoo-dev

2011-07-12 07:48:13 UTC

Thanks, committed.