Bug 374417 – dev-php/PEAR-PEAR: parentheses set wrong in files/symlink-attack-fix.patch

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Georg Hopp 2011-07-08 08:44:16 UTC]

While using pear i encountered some strangeness, i actually can't remember what exacly happend but i it took me to some obviously wrong set parentheses in the mentioned patch.

It can be found in line 39 of files/symlink-attack-fix.patch:

+            if (System::mkdir(array('-p', $cache_dir) === false)) {

this for sure has to be.

+            if (System::mkdir(array('-p', $cache_dir)) === false) {

I created a patch symlink-attack-fix-fix.patch that if applied after symlink-attack-fix-fix.patch fixes this line and the problems where gone.


Reproducible: Always

Steps to Reproduce:
1. use a config with an alternatively cache dir, that is not already created.
2. use pear with commands that need cache.
Actual Results:  
An error occured mentioning that no cache dir was found and can't be created.

Expected Results:  
cache dir should be created.

[Comment 1 Georg Hopp 2011-07-08 08:46:02 UTC]

Created attachment 279415 [details, diff]
patch to fix the patch. :D

[Comment 2 Ole Markus With (RETIRED) 2011-07-08 13:07:29 UTC]

Thanks for the fix.

I'll probably solve the issue by stabilising 1.9.3 which should have this fix included.

Cheers

[Comment 3 Ole Markus With (RETIRED) 2011-09-07 11:24:49 UTC]

Older versions removed now.