374109 – net-misc/dahdi should check for CRC_CCITT presence in kernel config

Bug 374109 - net-misc/dahdi should check for CRC_CCITT presence in kernel config

Summary: net-misc/dahdi should check for CRC_CCITT presence in kernel config

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Tony Vroon (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-07-05 08:54 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2011-07-05 10:49 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2011-07-05 08:54:21 UTC

I.e.:


--- dahdi-2.4.1.ebuild	28 Apr 2011 21:37:53 -0000	1.3
+++ dahdi-2.4.1.ebuild	5 Jul 2011 08:49:24 -0000
@@ -31,6 +31,8 @@
 EPATCH_SUFFIX="diff"
 PATCHES=( "${WORKDIR}/dahdi-patchset" )
 
+CONFIG_CHECK="CRC_CCITT"
+
 src_unpack() {
 	unpack ${A}
 	# Copy the firmware tarballs over, the makefile will try and download them otherwise


Without CRC_CCITT in kernel, dahdi module will try accessing the table reporting undefined symbol problems. This should really stop the build (so should go without ~), as you need to rebuild the module, if it was built against a kernel with it disabled.

Feel free to just give me the OK to commit, if you wish.

Thanks!
Diego

Comment 1 Tony Vroon (RETIRED) gentoo-dev

2011-07-05 08:57:30 UTC

Please proceed Diego, that looks sensible.

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev

2011-07-05 10:49:29 UTC

Committed, forgot to close earlier. Thanks!