Bug 373817 – media-libs/libmad is built with --enable-accuracy for no apparent reason

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Nikos Chantziaras 2011-07-02 14:33:57 UTC]

The current ebuilds for libmad use --enable-accuracy when building it. There doesn't seem to be a reason for this though (at least there isn't one mentioned in the ebuild or somewhere in the ChangeLog.)  From libmad's README:

"Note that you need not specify one of --enable-speed or --enable-accuracy; in its default configuration, MAD is optimized for both. You should only use one of these options if you wish to compromise speed or accuracy for the other."

I am attaching two patches.  One for the ebuild, which introduces "accuracy" and "speed" USE flags.  Both default to disabled (so that libmad will optimize for both), and they are made mutually exclusive using confutils_use_conflict() from the confutils eclass.  The other patch is for metadata.xml, which adds descriptions for the USE flags.

Reproducible: Always

[Comment 1 Nikos Chantziaras 2011-07-02 14:34:38 UTC]

Created attachment 278861 [details, diff]
Patch against libmad-0.15.1b-r7.ebuild

[Comment 2 Nikos Chantziaras 2011-07-02 14:35:06 UTC]

Created attachment 278863 [details, diff]
Patch for metadata.xml

[Comment 3 Matt Turner 2011-07-07 17:10:37 UTC]

I recommended adding an accuracy USE flag in bug 346521 but was met with resistance.

[Comment 4 Nikos Chantziaras 2012-02-15 16:45:15 UTC]

Closing this since there's no interest and it's not an important issue.