I run a very large font so I can see my screen from far away. I ran genkernel all --menuconfig and it continued right on past the crashing of menuconfig also when I lowered the font size, then expermeited with changing the terminal size, menuconfig quit and genkernel continued right on like I was done with menuconfig scripts/kconfig/mconf arch/i386/Kconfig # # using defaults found in .config # Your display is too small to run Menuconfig! It must be at least 19 lines by 80 columns. make[1]: *** [menuconfig] Error 1 make: *** [menuconfig] Error 2 * kernel: running clean or * kernel: Starting compile of linux 2.6 Your display is too small to run Menuconfig! It must be at least 19 lines by 80 columns. make[1]: *** [menuconfig] Error 1 make: *** [menuconfig] Error 2 * kernel: running clean Reproducible: Always Steps to Reproduce: 1.genkernel all --menuconfig --install (or just with menuconfig) 2.window size doesn't support menuconf gui 3.it just exits 4 and genkernel keeps on chugging away Actual Results: kernel compiled without my custom options Expected Results: not run, or switch to a different install mode
you MUST report what version of genkernel you're running I have not seen an instance where this happened but when a process crashes perhaps it is not returning a valid return code to bash for it to interpret anyhow. please try with 3.0.1_beta6
I gave instructions on how to reproduce the bug. I WAS using beta6!!!! or at least it reproducess on ALL genkernels because it is a limitation with menuconfig. Make your xterm window very small and run make menuconfig NO GENKERNEL involved. it will die saying that the xterm is too small, that it needs at least 80 characters wide or something like that. now enter genkernel: Genkernel continues right along compiling the kernel and stuff without having used menuconfig. Other note: I'm using konsole.. xterm might try to do something with the font size when the window is resized.... konsole reduces the number of columns and rows while maintaining the font size GenKernel v3.0.1_beta6 * ARCH: x86 * KERNEL VER: 2.6.1-gentoo-r1 * kernel: configuring source * kernel: running mrproper * kernel: using config from /usr/share/genkernel/x86/kernel-config-2.6 * kernel: running oldconfig * kernel: running menuconfig make[1]: `scripts/fixdep' is up to date. HOSTLD scripts/kconfig/mconf HOSTCC scripts/lxdialog/checklist.o HOSTCC scripts/lxdialog/inputbox.o HOSTCC scripts/lxdialog/lxdialog.o HOSTCC scripts/lxdialog/menubox.o HOSTCC scripts/lxdialog/msgbox.o HOSTCC scripts/lxdialog/textbox.o HOSTCC scripts/lxdialog/util.o HOSTCC scripts/lxdialog/yesno.o HOSTLD scripts/lxdialog/lxdialog scripts/kconfig/mconf arch/i386/Kconfig # # using defaults found in .config # Your display is too small to run Menuconfig! It must be at least 19 lines by 80 columns. make[1]: *** [menuconfig] Error 1 make: *** [menuconfig] Error 2 * kernel: running clean * kernel: skipping make dep for non 2.4 kernels * kernel: Starting compile of linux 2.6.1-gentoo-r1 bzImage (I control-c'd it here... it would also be nice if it says something like: genkernel cought signal--- exiting kernel not finished... actually that is a neccessity... but that's another bug.
Well, I'll have to look into the menuconfig thing. But I'm not going to try to figure out signal handling in bash, that's something I don't think will ever be necessary, we don't do anything that requires cleaning up, and I think a user can figure out when they hit CTRL-C or not.
Created attachment 24394 [details] /usr/share/genkernel/gen_configkernel.sh Barrowed code from genkernel 1.8 Commented out a line that added functionality to 1.8 that after menuconfig it copied the .config file to the appropriate place so it would be loaded the next time... I don't know what the current variables are (looking into it a bit) but this fixes the bug... please look into the additional functionality request when reviewing this (just a few lines all together with a comment right after make menuconfig)
Yikes, I just realized that make menuconfig is not ran if cleaning isn't on... If somebody specifies menuconfig... they want to do menuconfig... Often they just want to change one thing in the settings, that doesn't justify a make mrproper. I did not reorder the functions though... and btw, the aditional feature request was: make menuconfig should save the changes made in the config to the /etc/kernels directory so it comes up next time. and this functionality was a line commented out in the added code... but that wasn't tested.
all this is fixed in _beta8
