37365 – Webmin does not use SSL when ssl USE flag is set

Bug 37365 - Webmin does not use SSL when ssl USE flag is set

Summary: Webmin does not use SSL when ssl USE flag is set

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	x86 Linux

Importance:	High minor (vote)
Assignee:	Jeremy Huddleston (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-01-05 20:43 UTC by Joel Miles
Modified:	2004-03-11 11:26 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joel Miles 2004-01-05 20:43:03 UTC

There seems to be a typo in all the webmin ebuilds.  They do not active SSL properly during install when the ssl USE flag is set.  This patch should fix it (works for me):

Line 43 should be changed from:
use ssl sed -i 's:ssl=$ssl:ssl=1:' setup.sh

to:
use ssl && sed -i 's:ssl=$ssl:ssl=1:' ${D}/usr/libexec/webmin/setup.sh

Reproducible: Always
Steps to Reproduce:
1. USE=ssl emerge webmin

Actual Results:  
Going to http://server:10000 displays the login page.

Expected Results:  
Going to https://server:10000 should display the login page.

Portage 2.0.49-r20 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r3, 2.4.23_pre8-gss)
=================================================================
System uname: 2.4.23_pre8-gss i586 AMD-K6(tm) 3D processor
Gentoo Base System version 1.4.3.10
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=k6-2 -fomit-frame-pointer -pipe"
CHOST="i586-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/share/
config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-O3 -march=k6-2 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu 
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="apache2 berkdb gdbm imap innodb ldap ncurses pam readline sasl snmp sqlite 
ssl tcpd x86 zlib"

Comment 1 Jeremy Huddleston (RETIRED) gentoo-dev

2004-03-11 11:26:40 UTC

fixed in portage.  thanks.