Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 373429 - app-backup/rsnapshot-1.3.1-r2 new ebuild
Summary: app-backup/rsnapshot-1.3.1-r2 new ebuild
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-29 03:00 UTC by SpliFF
Modified: 2011-07-31 19:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rsnapshot-1.3.1-r2 ebuild (rsnapshot-1.3.1-r2.ebuild,1.47 KB, text/plain)
2011-06-29 03:06 UTC, SpliFF
Details
svn diff from 1.398 to 1.430 (rsnapshot-1.3.1-svn-fixes-1.398-1.430.patch,46.50 KB, patch)
2011-06-29 03:07 UTC, SpliFF
Details | Diff
files/rsnapshot-1.3.1-cp_al.patch (rsnapshot-1.3.1-cp_al.patch,535 bytes, patch)
2011-06-29 03:09 UTC, SpliFF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SpliFF 2011-06-29 03:00:33 UTC
The release schedule of rsnapshot is glacial. The current release 1.3.1 was packaged in August 2008 and contains at least one serious bug which prevents backup paths from containing spaces or special characters.

I have written a new ebuild and patch which updates the 1.3.1 release with a diff of all SVN commits from the 2008 release up to June 2011 (1.430). This fixes several important bugs including the issue with spaces.

Reproducible: Always
Comment 1 SpliFF 2011-06-29 03:06:04 UTC
Created attachment 278597 [details]
rsnapshot-1.3.1-r2 ebuild
Comment 2 SpliFF 2011-06-29 03:07:53 UTC
Created attachment 278599 [details, diff]
svn diff from 1.398 to 1.430
Comment 3 SpliFF 2011-06-29 03:09:04 UTC
Created attachment 278601 [details, diff]
files/rsnapshot-1.3.1-cp_al.patch
Comment 4 Daniel Robbins 2011-07-20 17:43:15 UTC
fyi, added to Funtoo Linux: https://github.com/funtoo/funtoo-overlay/commit/86b531303669361db84cc4db67661b90269f86a3

I will be testing it here.
Comment 5 Daniel Robbins 2011-07-20 17:51:46 UTC
Using the new rsnapshot:


ninja2 backup # ./backup.sh 
echo 8383 > /var/run/rsnapshot.pid 
mv /root/rsnapshot/daily.4/ /root/rsnapshot/daily.5/ 
mv /root/rsnapshot/daily.3/ /root/rsnapshot/daily.4/ 
mv /root/rsnapshot/daily.2/ /root/rsnapshot/daily.3/ 
mv /root/rsnapshot/daily.1/ /root/rsnapshot/daily.2/ 
native_cp_al("/root/rsnapshot/daily.0", "/root/rsnapshot/daily.1") 
----------------------------------------------------------------------------
rsnapshot encountered an error! The program was invoked with these options:
/usr/bin/rsnapshot -v daily 
----------------------------------------------------------------------------
ERROR: rsync_cleanup_after_native_cp_al() only works on directories
ERROR: Error! cp_al("/root/rsnapshot/daily.0/", "/root/rsnapshot/daily.1/")
rm -f /var/run/rsnapshot.pid 
failure: rsnapshot
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-07-31 19:33:33 UTC
I'm not going to add a _revbump_ with a SVN snapshot, and I won't be patching it either. If you wish to submit an ebuild ofr an SVN snapshot, it should use a specific tarball with the SVN sources (and not their .svn directories either).

But since Daniel also shown that it doesn't work as good as it is supposed to, I'd rather hope that you can bring the release up with upstream....