Bug 373413 – gnome-base/gdm plymouth support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Florian Scandella 2011-06-28 22:11:00 UTC]

it would be nice to have plymouth support in gdm. i got it working with a patch from the fedora source. had to split the patch up because epatch does not handle patches that patch the same file multiple times (because of --dry-run). also, had to modify some small parts of the patch to apply cleanly.
i don't know what upstreams plan is, the git branch of gdm where this patch comes from (http://git.gnome.org/browse/gdm/log/?h=plymouth-integration) is over 1 year old.



Reproducible: Always

[Comment 1 Florian Scandella 2011-06-28 22:12:00 UTC]

Created attachment 278565 [details, diff]
plymouth patch part1

[Comment 2 Florian Scandella 2011-06-28 22:12:14 UTC]

Created attachment 278567 [details, diff]
plymouth patch part2

[Comment 3 Florian Scandella 2011-06-28 22:12:28 UTC]

Created attachment 278569 [details, diff]
plymouth patch part3

[Comment 4 Gilles Dartiguelongue (RETIRED) 2011-06-29 10:39:47 UTC]

This would be best reported upstream.

[Comment 5 Luis Medinas 2011-06-29 14:10:29 UTC]

Link of the patch from openSUSE https://build.opensuse.org/package/view_file?file=gdm-plymouth.patch&package=gdm&project=openSUSE%3AFactory&srcmd5=5de256b7e945cb4174ccbf451750a437

this applies on 3.0.4. Please commit this patch to the overlay since other distros are maintaining this patch (ubuntu, opensuse, fedora) gentoo can maintain it too. This makes desktop experience much better.

[Comment 6 Gilles Dartiguelongue (RETIRED) 2011-06-29 14:21:37 UTC]

It should be reported upstream before we even consider adding it to the tree or the overlay.

[Comment 7 Alexandre Rostovtsev (RETIRED) 2011-06-29 20:05:40 UTC]

(In reply to comment #6)
> It should be reported upstream before we even consider adding it to the tree or
> the overlay.

Plymouth support is already in upstream, only it's not in master or gnome-3-0, but in a separate branch.

[Comment 8 Pacho Ramos 2011-07-15 11:41:50 UTC]

Would be nice to know why upstream hasn't merged it to master yet :-/

[Comment 9 Pacho Ramos 2011-12-17 15:04:49 UTC]

I would close this as WONTFIX until upstrea merges that branch into master, otherwise I think this will be hard to maintain (and prone to breakage)

[Comment 10 Alexandre Rostovtsev (RETIRED) 2011-12-29 02:52:22 UTC]

(In reply to comment #9)
> I would close this as WONTFIX until upstrea merges that branch into master,
> otherwise I think this will be hard to maintain (and prone to breakage)

Perhaps we can rely on Fedora to keep the patches updated?
http://pkgs.fedoraproject.org/gitweb/?p=gdm.git;a=history;f=plymouth.patch

[Comment 11 Luis Medinas 2012-01-30 15:12:01 UTC]

(In reply to comment #10)
> (In reply to comment #9)
> > I would close this as WONTFIX until upstrea merges that branch into master,
> > otherwise I think this will be hard to maintain (and prone to breakage)
> 
> Perhaps we can rely on Fedora to keep the patches updated?
> http://pkgs.fedoraproject.org/gitweb/?p=gdm.git;a=history;f=plymouth.patch

Yes, fedora is upstream for this patch and almost all distros are shipping this patch to support plymouth on gdm.

Please add this patch so we can have a smooth transition from plymouth to gdm.

[Comment 12 Alexandre Rostovtsev (RETIRED) 2012-05-14 04:52:53 UTC]

Plymouth support patches have finally landed in gdm upstream git master, and therefore I have added them to gdm-3.4.1. Please test it; I cannot run plymouth since I use nvidia-drivers.