I am unable to compile miniupnpd-1.5 net-misc/miniupnpd-1.5 failed LANG=C LDFLAGS="" CFLAGS="-march=i686 -O2" emerge -av miniupnpd i686-pc-linux-gnu-gcc -march=i686 -O2 -I/usr/src/linux/include -D_GNU_SOURCE -DIPTABLES_143 -DIPTABLES_143 -c -o testgetifstats.o testgetifstats.c i686-pc-linux-gnu-gcc -march=i686 -O2 -I/usr/src/linux/include -D_GNU_SOURCE -DIPTABLES_143 -DIPTABLES_143 -c -o testupnppermissions.o testupnppermissions.c In file included from /usr/include/libiptc/libiptc.h:5:0, from netfilter/iptcrdr.c:16: /usr/src/linux/include/linux/types.h:13:2: Warnung: #warning "Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders" [-Wcpp] i686-pc-linux-gnu-gcc -march=i686 -O2 -I/usr/src/linux/include -D_GNU_SOURCE -DIPTABLES_143 -DIPTABLES_143 -c -o miniupnpdctl.o miniupnpdctl.c i686-pc-linux-gnu-gcc -march=i686 -O2 -I/usr/src/linux/include -D_GNU_SOURCE -DIPTABLES_143 -DIPTABLES_143 -c -o testgetifaddr.o testgetifaddr.c i686-pc-linux-gnu-gcc miniupnpd.o upnphttp.o upnpdescgen.o upnpsoap.o upnpreplyparse.o minixml.o upnpredirect.o getifaddr.o daemonize.o upnpglobalvars.o options.o upnppermissions.o minissdp.o natpmp.o upnpevents.o linux/getifstats.o netfilter/iptcrdr.o /usr/lib/libip4tc.so /usr/lib/libiptc.a -o miniupnpd In file included from /usr/include/asm/sigcontext.h:5:0, from /usr/include/bits/sigcontext.h:28, from /usr/include/signal.h:339, from miniupnpdctl.c:15: /usr/src/linux/include/linux/types.h:13:2: Warnung: #warning "Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders" [-Wcpp] i686-pc-linux-gnu-gcc testupnpdescgen.o upnpdescgen.o -o testupnpdescgen i686-pc-linux-gnu-gcc testgetifstats.o linux/getifstats.o -o testgetifstats i686-pc-linux-gnu-gcc testupnppermissions.o upnppermissions.o -o testupnppermissions netfilter/iptcrdr.o: In function `get_tcp_match': iptcrdr.c:(.text+0x4f): undefined reference to `IPT_ALIGN' iptcrdr.c:(.text+0x5d): undefined reference to `IPT_ALIGN' netfilter/iptcrdr.o: In function `get_udp_match': iptcrdr.c:(.text+0xdf): undefined reference to `IPT_ALIGN' iptcrdr.c:(.text+0xed): undefined reference to `IPT_ALIGN' netfilter/iptcrdr.o: In function `addnatrule': iptcrdr.c:(.text+0xa66): undefined reference to `IPT_ALIGN' netfilter/iptcrdr.o:iptcrdr.c:(.text+0xa74): more undefined references to `IPT_ALIGN' follow collect2: ld returned 1 exit status make: *** [miniupnpd] Error 1 make: *** Waiting for unfinished jobs.... emake failed * ERROR: net-misc/miniupnpd-1.5 failed (compile phase): * emake failed * * Call stack: * ebuild.sh, line 56: Called src_compile * environment, line 2983: Called die * The specific snippet of code: * emake CC="$(tc-getCC)" || die "emake failed" * * If you need support, post the output of 'emerge --info =net-misc/miniupnpd-1.5', * the complete build log and the output of 'emerge -pqv =net-misc/miniupnpd-1.5'. * The complete build log is located at '/var/tmp/portage/net-misc/miniupnpd-1.5/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/net-misc/miniupnpd-1.5/temp/environment'. * S: '/var/tmp/portage/net-misc/miniupnpd-1.5/work/miniupnpd-1.5' Reproducible: Always
Galactica ~ # emerge --info Portage 2.1.10.3 (default/linux/x86/10.0/server, gcc-4.6.0, glibc-2.13-r2, 2.6.39-gentoo-r2 i686) ================================================================= System uname: Linux-2.6.39-gentoo-r2-i686-Intel-R-_Atom-TM-_CPU_N270_@_1.60GHz-with-gentoo-2.0.3 Timestamp of tree: Tue, 28 Jun 2011 10:00:01 +0000 ccache version 3.1.5 [enabled] app-shells/bash: 4.2_p10 dev-lang/python: 2.7.2, 3.2 dev-util/ccache: 3.1.5 dev-util/pkgconfig: 0.26 sys-apps/baselayout: 2.0.3 sys-apps/openrc: 0.8.3-r1 sys-apps/sandbox: 2.5 sys-devel/autoconf: 2.68 sys-devel/automake: 1.11.1-r1 sys-devel/binutils: 2.21.1 sys-devel/gcc: 4.6.0 sys-devel/gcc-config: 1.4.1-r1 sys-devel/libtool: 2.4-r1 sys-devel/make: 3.82-r1 sys-kernel/linux-headers: 2.6.38 (virtual/os-headers) sys-libs/glibc: 2.13-r2 Repositories: gentoo ACCEPT_KEYWORDS="x86 ~x86" ACCEPT_LICENSE="* -@EULA" CBUILD="i686-pc-linux-gnu" CFLAGS="-march=atom -O2 -mmovbe -msahf -pipe -fomit-frame-pointer -mfpmath=sse" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo" CXXFLAGS="-march=atom -O2 -mmovbe -msahf -pipe -fomit-frame-pointer -mfpmath=sse -fvisibility-inlines-hidden" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--autounmask=n" FEATURES="assume-digests binpkg-logs ccache distlocks ebuild-locks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch" FFLAGS="" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="de_DE.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--sort-common -Wl,-z,now" LINGUAS="de" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_COMPRESS="gzip" PORTAGE_COMPRESS_FLAGS="-f9" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="bash-completion bzip2 cracklib iconv idn ipv6 lzma ncurses nls nptl pam png readline slang spell sse2 ssl symlink tcpd threads unicode vim-syntax x86 xml zeroconf zlib" ELIBC="glibc" KERNEL="linux" LINGUAS="de" USERLAND="GNU" Unset: CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS
Current Version http://miniupnp.free.fr/files/download.php?file=miniupnpd-1.5.20110623.tar.gz works fine! It's an issue with the newest iptables.
miniupnpd-1.3-iptables_path.diff and miniupnpd-1.5-iptcrdr.diff are in this version, so they are not needed anymore.
Created attachment 278551 [details] miniupnpd-1.5_pre20110623.ebuild
Created attachment 278553 [details] miniupnpd.diff against 1.5 ebuild
As I understand miniupnpd-1.5.20110623 is release candidate and thus it's good idea to hardmask it. It's good idea to backport patch for 1.5, I've requested patch here: http://miniupnp.tuxfamily.org/forum/viewtopic.php?t=771
I'll bump it later today. Not going to hardmask it just because it's release candidate (going for ~arch), since thats where the version of iptables that makes problems is placed. Also, if people want stable only packages, they should stick to arch and not use ~arch :-) If we get a patch for 1.5 that has support for the newest iptables, I'll create a -r1 ebuild with it :)
(In reply to comment #7) > I'll bump it later today. > > Not going to hardmask it just because it's release candidate (going for ~arch), > since thats where the version of iptables that makes problems is placed. > > Also, if people want stable only packages, they should stick to arch and not > use ~arch :-) Please, read '~ARCH in KEYWORDS' section of our documentation: http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1#doc_chap4 Such packages should be masked. > If we get a patch for 1.5 that has support for the newest iptables, I'll create > a -r1 ebuild with it :) No need too do revbump for build fixes.
Ahh yes, from what I can read, it is depending on whether upstream marks it as in development and not suggested to users. From the handbook: "if Gimp decides to release an unstable/development series marked as 1.3.0, then these ebuilds should be put in package.mask because the software itself is of development quality and is not recommended by the developers for distribution." So the question really is, if upstream recommends using the latest build, or the 1.5 build :)
Well, the older ebuils, which where also not final versions, were only put in ~arch, but not masked.
(In reply to comment #9) > So the question really is, if upstream recommends using the latest build, or > the 1.5 build :) Right. And taking into account that same upstream packs miniupnpc with similar versions and that 1.5.20110618 is broken (has still, but API is completely different from 1.5 release) I guess that this miniupnpd may be completely broken also until proved different.
I've added it to the tree as 1.6_pre20110623, since it's going to be 1.6, and not 1.5 :-) Also, I've kept it in ~arch to help people having problem building against newest iptables.
(In reply to comment #12) > I've added it to the tree as 1.6_pre20110623, since it's going to be 1.6, and > not 1.5 :-) Patch for iptables is available. Please, backport it.
(In reply to comment #13) > (In reply to comment #12) > > I've added it to the tree as 1.6_pre20110623, since it's going to be 1.6, and > > not 1.5 :-) > > Patch for iptables is available. Please, backport it. Do you have a link to the patch? (I haven't been able to find it) :-)
Index: iptcrdr.c =================================================================== RCS file: /usr/local/cvsroot/miniupnp/miniupnpd/linux/iptcrdr.c,v retrieving revision 1.43 retrieving revision 1.44 diff -u -r1.43 -r1.44 --- iptcrdr.c 4 Jun 2011 08:57:41 -0000 1.43 +++ iptcrdr.c 20 Jun 2011 14:03:24 -0000 1.44 @@ -1,4 +1,4 @@ -/* $Id: iptcrdr.c,v 1.43 2011/06/04 08:57:41 nanard Exp $ */ +/* $Id: iptcrdr.c,v 1.44 2011/06/20 14:03:24 nanard Exp $ */ /* MiniUPnP project * http://miniupnp.free.fr/ or http://miniupnp.tuxfamily.org/ * (c) 2006-2011 Thomas Bernard @@ -43,6 +43,11 @@ #define IPTC_HANDLE iptc_handle_t #endif +/* IPT_ALIGN was renamed XT_ALIGN in iptables-1.4.11 */ +#ifndef IPT_ALIGN +#define IPT_ALIGN XT_ALIGN +#endif + #include "iptcrdr.h" #include "../upnpglobalvars.h" @@ -883,7 +888,8 @@ array = realloc(array, sizeof(unsigned short)*capacity); if(!array) { - syslog(LOG_ERR, "get_portmappings_in_range() : realloc(%lu) error", sizeof(unsigned short)*capacity); + syslog(LOG_ERR, "get_portmappings_in_range() : realloc(%u) error", + (unsigned)sizeof(unsigned short)*capacity); *number = 0; break; }
Created attachment 278815 [details] iptables-patch.txt
I have fixed the patch and applied it (the 1. and 3. section in it fails, and isn't needed to build - section 1 just changes the header, section 3 touches get_portmappings_in_range() which isn't even in the file... ). Anyway, it builds now :) Please reopen if it for some reason does not work.
