There's a bug in the cue plugin. A new cue files cannot be added to the playlist because a variable gets free()'d twice. Already added files can still be played from the playlist. Reproducible: Always Steps to Reproduce: 1. Add .cue file to audacious playlist Actual Results: Audacious crashes Expected Results: The cue file's songs are added to the playlist. It's already fixed upstream by partially refactoring the plugin for the next version.
Created attachment 278295 [details, diff] Patch to once again support adding cue files to the playlist
Please link to the upstream commit in question using the URL field. It sounds like a 2.5.3 release should be made. (I do not generally apply local patching to Audacious)
There have been multiple commits to this file in the past due to API and signature changes, but I can't even figure out which version is in portage and thus which commit fixed it. The last commit, 9b225dff3798, is already 5 weeks old and thus much older than the 2.5.2 ebuild and it's snapshot or even 2.5.1 for that matter. At least that's what I get from the official hg repository. Commit 881a233796b1 changed playlist_load_cue's signature on Apr 21 2011, but the old one is still used in the ebuild/snapshot from Jun 24 2011. Either I'm too dull to figure out my "hg log cue.c" output or something's way off.
You want the GIT viewer at git.atheme.org; specifically the audacious/audacious-plugins repositories for "trunk" and the releases/audacious-2.5.x & releases/audacious-plugins-2.5.x for comparison.
Guess you should update http://audacious-media-player.org/developers then ;) I hadn't looked at the hg commit dates, so I didn't notice the version in hg was much older. So after checking the much more up to date git repo, the same bug is still in the master branch as of a few minutes ago. Hope that helps.
Thank you for your report; please see the linked GIT commit. A 2.5.3 release is pending which will include this fix. I will keep your report open until said release hits portage.
Thanks for taking care of this bug so fast! For reference sake, git commit 815aa5b0 introduced the first g_free call that eventually lead to this bug because the second one wasn't changed.
+*audacious-2.5.3 (29 Jun 2011) + + 29 Jun 2011; Tony Vroon <chainsaw@gentoo.org> +audacious-2.5.3.ebuild: + Bugfix release; root to non-root path relocation is now handled correctly in + all cases. +*audacious-plugins-2.5.3 (29 Jun 2011) + + 29 Jun 2011; Tony Vroon <chainsaw@gentoo.org> + +audacious-plugins-2.5.3.ebuild: + Bugfix release; restores compatibility with newest libav/ffmpeg and addresses + double free in the cue plugin. Closes bug #373157 by shinydoofy.
I have, again, this issue with version 2.5.{2,3,4}, at least the updated versions. I don't get a thing about it because the change was introduced by upstream for 2.5.4 and 3.0 version. I checked the src/cue/cue.c file and the change is there for 2.5.{3,4} and 3.0. However, adding new .cue files seems to work only with 3.0 and not 2.5.{3,4} anymore. I'm not upgrading to 3.0 version because I have an issue with the GUI, the new gtk3 support cause the GUI not being themed on a gnome-2.30 DE. I'm not sure if it's a bug but I noticed it since the 3_alpha1 release that's why I'm avoiding it. Now I have no choice: no .cue files or not correctly themed GUI. Which one I prefer? -- Darn, I'd like the two. And yes, I tried merging back an old 2.5.3 pkg version which I built when that patch introduced and... it doesn't work anymore. I wonder what could be the cause of that regression--I updated to much stuff to remember a possible source of it without taking into account the glibc-2.13-r3 issue, nvidia-drivers-275.19 issue... which were real headaches.
