The pine patch pine-4.44-multibyte.patch really messes up Pine in a lot of ways. I recommend removing it. In particular, in some terminals (e.g., xterm), it causes the erase character to not delete newlines. It also causes Pine to abort if you postpone composing a message. Furthermore, it causes problems if you are inserting text into the middle of a line, and the line wraps as you type into the next line, it causes major problems in the text you type (really wierd stuff).
what is this patch for? I can't seem to find anything about it anywhwere. there's no mention of what it's for in the ebuild.
$ ls -l /usr/portage/net-mail/pine/files/pine-4.44-multibyte.patch -rw-r--r-- 1 root root 3704 Feb 21 17:24 /usr/portage/net-mail/pine/files/pine-4.44-multibyte.patch $ grep multibyte /usr/portage/net-mail/pine/pine-4.44-r4.ebuild patch -d ${S} -p1 < ${FILESDIR}/pine-4.44-multibyte.patch
Right, and my question was "What is it for?" I can see that it's there....
Beats me. ChangeLog commit was: Revamped our ebuild to use RH patches so that I could include SSL and LDAP support (both controlled by use variables). I don't know enough about pine to test it properly.
I've posted in the forums about this ( http://forums.gentoo.org/viewtopic.php?p=64226 ) before thinking to check if there was an actual bug on this. I see that there is. I confirm the "really weird stuff" problems when composing a message. Note that the weird stuff didn't seem to happen when I used vi as the message editor, but that was just a pain in the butt for typing email. Have you confirmed that this behavior is gone if you comment out the patch line in the ebuild?
Yes, the problem does go away with the patch line commented out.
I haven't looked at all that is in the patch. I do need LDAP support in my pine though. Am I to understand that LDAP support won't be compiled in without this patch? If that is the case then we need to identify which part of this patch is the problem. Who wrote the patch?
Why are you mentioning LDAP? This patch has nothing to do with LDAP.
Comment #4 mentioned something about LDAP and SSL and I thought it was implying that the patch was addressing those issues.
Confirming that commenting out multibyte patch fixed the problem. It seems that no one knows what it does, except screw things up. Why don't we comment it out in the CVS ebuild for now?
RedHat's bugzilla describes the patch as relating to Asian character sets: http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=58971 The patch is unrelated to SSL and LDAP, as the ChangeLog might erroneously imply. Note these comments from RedHat's bugzilla: Additional comment by terbak@add.no 2002-03-16 19:04:18 This patch is way broken with pine: the word-wrapping is broken, backspace on first column does not bring the text up one line, and pine crashes when writing a bit. Additional comment by mharris@redhat.com 2002-03-17 11:37:37 Indeed. Patch removed from pine-4.44-6 release for stabilization. At this point I will not permit this patch to be included as it can interfere with the standard operation of PINE. Such enhancements should be made by submitting patches to the PINE team themselves. Thanks terbak for tracking the wordwrap problem down.
commented out the patch line in cvs.
