Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 371759 - app-emulation/ganeti init script should not apply masterd daemon options to other daemons
Summary: app-emulation/ganeti init script should not apply masterd daemon options to o...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Lance Albertson (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 13:21 UTC by Heiko Baumann
Modified: 2012-05-12 08:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Baumann 2011-06-15 13:21:44 UTC
if one set GANETI_MASTERD_OPTS (e.g. --no-voting --yes-do-it on a two node cluster) this options are also passed to ganeti-confd and ganeti-rapi because GANETI_OPTS variable modified.

the following patch works for me:

--- ganeti-2.1.initd.org        2011-03-01 22:01:47.000000000 +0100
+++ ganeti-2.1.initd    2011-06-15 15:11:24.000000000 +0200
@@ -70,15 +70,16 @@
 start_all() {
     check_config
     for i in ${NODED} ${MASTERD} ${CONFD} ${RAPI}; do \
+       GANETI_START_OPTS="${GANETI_OPTS}"
         case "${i}" in
             ganeti-masterd)
-                GANETI_OPTS="${GANETI_OPTS} ${GANETI_MASTERD_OPTS}"
+                GANETI_START_OPTS="${GANETI_START_OPTS} ${GANETI_MASTERD_OPTS}"
                 ;;
             ganeti-rapid)
-                GANETI_OPTS="${GANETI_OPTS} ${GANETI_RAPI_OPTS}"
+                GANETI_START_OPTS="${GANETI_START_OPTS} ${GANETI_RAPI_OPTS}"
                 ;;
         esac
-        maybe_do "${1}" start_action ${i} ${GANETI_OPTS}
+        maybe_do "${1}" start_action ${i} ${GANETI_START_OPTS}
     done
 }
 


Reproducible: Always

Steps to Reproduce:
1. set GANETI_MASTERD_OPTS in /etc/conf.d/ganeti
2. /etc/init.d/ganeti restart

Actual Results:  
ganeti-confd and ganeti-rapi fails to start because the dont know ganeti-masterd options like --no-voting

Expected Results:  
all deamons should start
Comment 1 Lance Albertson (RETIRED) gentoo-dev 2012-05-12 08:11:18 UTC
Finally fixed and pushed to portage. Thanks for reporting. Sorry it took so long :(